90699[BUGFIX] Remove default install tool session handler options
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Markus Klein +1
- Sven Liebert +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Markus Klein +1
- Sven Liebert +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1317
-
Sven Liebert uploaded patch set 1 09/17/25, 07:27
-
Sven Liebert updated the commit message in patch set 2 09/17/25, 07:33
-
core-ci voted on patch set 1 V +1 09/17/25, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85061
-
Mathias Brodala commented on patch set 2 09/17/25, 07:38
-
Benjamin Franzke updated the commit message in patch set 3 09/17/25, 07:41
-
core-ci voted on patch set 2 V +1 09/17/25, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85062
-
Sven Liebert commented on patch set 3 09/17/25, 07:44
FileSessionHandler.php:49ReplyI wouldn't do that here. If its null it will be set later. But we can not ensure that the user configured it correct. So when we not use DefaultConfiguration.php, I would asume that it could be possible null. It wouldn't make a difference for the user because we built this failsafe so it would configured correctly in the fallback. I'm not sure about that. @ben@bnf.dev do you have any thoughts about that? -
Benjamin Franzke uploaded patch set 4
CR +1V +109/17/25, 07:45 -
core-ci voted on patch set 3 V +1 09/17/25, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85063
-
Sven Liebert voted on patch set 4 CR +1 V +1 09/17/25, 07:53
-
core-ci voted on patch set 4 V +1 09/17/25, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85064
-
Benjamin Franzke commented on patch set 4 09/17/25, 07:55
FileSessionHandler.php:49ReplyI'm actually not quite sure (yet). I've stumbled over this new setting while working on upcoming system settings and this actually showed quite a new usecase: Should there be dynamic defaults at all? I'm not sure yet, but we also want(ed) to avoid nullable options (which is the current fix). So yea, I'm not sure if nullable is cool, but that's basically a consequence of this direct options-to-constructor unfolding we are doing in SessionService. So, I'd like to get this fix in right now and offload the design decision to a later phase, as it really depends on how we continue with the settings API. -
Sven Liebert commented on patch set 4 09/17/25, 08:00
FileSessionHandler.php:49ReplyAcknowledged -
Markus Klein voted on patch set 4 CR +1 V +1 09/17/25, 08:20
-
Oliver Klee voted on patch set 4 CR +1 09/17/25, 08:22
-
Benjamin Franzke voted on patch set 4 CR +2 V +2 09/17/25, 08:26
-
Benjamin Franzke merged patch set 5 09/17/25, 08:26
FileSessionHandler.php:49