Review main Merged

90699[BUGFIX] Remove default install tool session handler options

Sven Liebert CR +2 V +2 Easy +4 −9 updated 09/17/25, 08:26

Commit message

Ensure default install tool session handler options do not interfere
with custom handler options, which otherwise result in an error like:

  Session handler is not configured properly:
  Unknown named parameter $sessionPath

Due to the default configured sessionPath for FileSessionHandler the
property is unknown to RedisSessionHandler and must therefore not be
present in DefaultConfiguration.php

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Markus Klein +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1317

  1. Sven Liebert uploaded patch set 1 09/17/25, 07:27

  2. Sven Liebert updated the commit message in patch set 2 09/17/25, 07:33

  3. core-ci voted on patch set 1 V +1 09/17/25, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85061

  4. Mathias Brodala commented on patch set 2 09/17/25, 07:38

    FileSessionHandler.php:49

    Does this really need to be nullable? If possible, we should keep it strict.
  5. Benjamin Franzke updated the commit message in patch set 3 09/17/25, 07:41

  6. core-ci voted on patch set 2 V +1 09/17/25, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85062

  7. Sven Liebert commented on patch set 3 09/17/25, 07:44

    FileSessionHandler.php:49 Reply

    I wouldn't do that here. If its null it will be set later. But we can not ensure that the user configured it correct. So when we not use DefaultConfiguration.php, I would asume that it could be possible null. It wouldn't make a difference for the user because we built this failsafe so it would configured correctly in the fallback. I'm not sure about that. @ben@bnf.dev do you have any thoughts about that?
  8. Benjamin Franzke uploaded patch set 4 CR +1 V +1 09/17/25, 07:45

  9. core-ci voted on patch set 3 V +1 09/17/25, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85063

  10. Sven Liebert voted on patch set 4 CR +1 V +1 09/17/25, 07:53

  11. core-ci voted on patch set 4 V +1 09/17/25, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85064

  12. Benjamin Franzke commented on patch set 4 09/17/25, 07:55

    FileSessionHandler.php:49 Reply

    I'm actually not quite sure (yet). I've stumbled over this new setting while working on upcoming system settings and this actually showed quite a new usecase: Should there be dynamic defaults at all? I'm not sure yet, but we also want(ed) to avoid nullable options (which is the current fix). So yea, I'm not sure if nullable is cool, but that's basically a consequence of this direct options-to-constructor unfolding we are doing in SessionService. So, I'd like to get this fix in right now and offload the design decision to a later phase, as it really depends on how we continue with the settings API.
  13. Sven Liebert commented on patch set 4 09/17/25, 08:00

    FileSessionHandler.php:49 Reply

    Acknowledged
  14. Markus Klein voted on patch set 4 CR +1 V +1 09/17/25, 08:20

  15. Oliver Klee voted on patch set 4 CR +1 09/17/25, 08:22

  16. Benjamin Franzke voted on patch set 4 CR +2 V +2 09/17/25, 08:26

  17. Benjamin Franzke merged patch set 5 09/17/25, 08:26