Review main Merged Breaking

90702[!!!][TASK] Remove TypoScript getTSFE() condition function

Christian Kuhn CR +2 V +2 Normal +50 −75 updated 09/19/25, 12:48

Commit message

To proceed with the removal of the TypoScriptFrontendController
god class, a few integrator related features have to be removed
before 14.0.

This change is about the 'getTSFE()' TypoScript condition
function which can be substituted with different conditions
quite easily.

While it would be relatively easy to create a b/w compat layer
that does not depend on TypoScriptFrontendController for this
function to continue to work, the decision is to remove it
entirely: We want to fully get rid of the keyword "TSFE" to
avoid this unfortunate wording, so the removal involves the
TypoScript references as well.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1317

  1. Christian Kuhn uploaded patch set 1 09/17/25, 12:43

  2. core-ci voted on patch set 1 V +1 09/17/25, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85072

  3. Christian Kuhn uploaded patch set 2 V +1 09/17/25, 12:54

  4. Christian Kuhn voted on patch set 2 CR -1 09/17/25, 12:54

  5. core-ci voted on patch set 2 V +1 09/17/25, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85078

  6. Christian Kuhn uploaded patch set 3 CR -1 V +1 09/17/25, 13:24

  7. core-ci voted on patch set 3 V +1 09/17/25, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85079

  8. Oliver Klee voted on patch set 3 CR +1 09/17/25, 14:56

  9. Chris Müller commented on patch set 3 CR -1 09/17/25, 16:32

    Breaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:16

    After various ... like -> here is missing something, maybe "functions"?

    Breaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:17

    "... have been removed ..."

    Breaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:20

    getTSFE().id
  10. Garvin Hicking commented on patch set 3 09/17/25, 19:03

    "entierly" typo also use "keyword" instead of first "wording" to prevent an odd wording ;)

    Breaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:47

    would request?.... also work, to prevent an AND condition and make it shorter?
  11. Christian Kuhn uploaded patch set 4 CR +1 V +1 09/19/25, 09:12

  12. core-ci voted on patch set 4 V +1 09/19/25, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85154

  13. Christian Kuhn commented on patch set 4 09/19/25, 11:58

    Reply

    Done

    Breaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:16 Reply

    Done

    Breaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:17 Reply

    Done

    Breaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:20 Reply

    Done

    Breaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:47 Reply

    Done
  14. Garvin Hicking voted on patch set 4 CR +1 V +1 09/19/25, 11:58

  15. Andreas Kienast voted on patch set 4 CR +1 V +1 09/19/25, 11:59

  16. Christian Kuhn voted on patch set 4 CR +2 V +2 09/19/25, 12:48

  17. Christian Kuhn merged patch set 5 09/19/25, 12:48