90702[!!!][TASK] Remove TypoScript getTSFE() condition function
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Andreas Kienast +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 3
- typo3/sysext/core/Classes/ExpressionLanguage/FunctionsProvider/Typo3ConditionFunctionsProvider.php+0 −23
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst8new+50 −0
- typo3/sysext/core/Tests/Functional/ExpressionLanguage/ResolverTest.phpdeleted+0 −52
Review log 1317
-
Christian Kuhn uploaded patch set 1 09/17/25, 12:43
-
core-ci voted on patch set 1 V +1 09/17/25, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85072
-
Christian Kuhn uploaded patch set 2
V +109/17/25, 12:54 -
Christian Kuhn voted on patch set 2 CR -1 09/17/25, 12:54
-
core-ci voted on patch set 2 V +1 09/17/25, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85078
-
Christian Kuhn uploaded patch set 3
CR -1V +109/17/25, 13:24 -
core-ci voted on patch set 3 V +1 09/17/25, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85079
-
Oliver Klee voted on patch set 3 CR +1 09/17/25, 14:56
-
Chris Müller commented on patch set 3 CR -1 09/17/25, 16:32
Breaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:17"... have been removed ..."Breaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:20getTSFE().id -
Garvin Hicking commented on patch set 3 09/17/25, 19:03
"entierly" typo also use "keyword" instead of first "wording" to prevent an odd wording ;)Breaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:47would request?.... also work, to prevent an AND condition and make it shorter? -
Christian Kuhn uploaded patch set 4
CR +1V +109/19/25, 09:12 -
core-ci voted on patch set 4 V +1 09/19/25, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85154
-
Christian Kuhn commented on patch set 4 09/19/25, 11:58
Reply
DoneBreaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:16ReplyDoneBreaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:17ReplyDoneBreaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:20ReplyDoneBreaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:47ReplyDone -
Garvin Hicking voted on patch set 4 CR +1 V +1 09/19/25, 11:58
-
Andreas Kienast voted on patch set 4 CR +1 V +1 09/19/25, 11:59
-
Christian Kuhn voted on patch set 4 CR +2 V +2 09/19/25, 12:48
-
Christian Kuhn merged patch set 5 09/19/25, 12:48
Breaking-107473-TypoScriptConditionFunctionGetTSFERemoved.rst:16