90715[!!!][TASK] Remove Environment::getComposerRootPath()
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Oliver Klee +1
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Helmut Hummel +2
- Oliver Klee +1
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/Core/Environment.php+0 −27
- typo3/sysext/core/Classes/Package/Package.php+1 −1
- typo3/sysext/core/Classes/Utility/PathUtility.php+2 −2
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107482-EnvironmentGetComposerRootPathMethodsRemoved.rst4new+50 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
- typo3/sysext/rte_ckeditor/Tests/Functional/Form/Element/RichTextElementTest.php4+2 −2
Review log 1317
-
Helmut Hummel uploaded patch set 1 09/17/25, 21:14
-
core-ci voted on patch set 1 V -1 09/17/25, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85100
-
Helmut Hummel uploaded patch set 2
V -109/17/25, 21:52 -
core-ci voted on patch set 2 V +1 09/17/25, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85103
-
Benni Mack commented on patch set 2 09/18/25, 07:14
Breaking-107482-EnvironmentGetComposerRootPathMethodsRemoved.rst:15TYPO3 v14.0 -
Garvin Hicking commented on patch set 2 09/18/25, 07:28
RichTextElementTest.php:66Could you tell why the asset hash here changes with this patch? Probably because the used path structure changes slightly (prefixed or suffixed slashes?!) I wonder if we should mention this in the breaking RST. Some people might have their extensions _assets directories referenced statically (symlinks and such) and might lead to broken asset references if people do not adjust to that. I know that is bad practice, and everywhere we state "please don't", but I've sadly seen people do this as an easy workaround for full path links to assets of extensions. Something like: "This patch changes how asset hashes are calculated. Asset directory names based on these hashes should never be specifically refererred to (for example in CSS/JS references) and better use relative references or static routes. Be sure to remove or at least adapt such references with this breaking change."? -
Helmut Hummel uploaded patch set 3
V +109/18/25, 20:30 -
Helmut Hummel commented on patch set 2 09/18/25, 20:30
Breaking-107482-EnvironmentGetComposerRootPathMethodsRemoved.rst:6ReplyDoneBreaking-107482-EnvironmentGetComposerRootPathMethodsRemoved.rst:15ReplyDoneRichTextElementTest.php:66ReplyActually, there will be no user facing hash change. The hash change in the test is required, because of the awkward test setup TYPO3 is using where there is a global Composer installation, but the tests are executed inside a fake non composer environment, while the test here again tries to fake a Composer mode, resulting in a wrong prefix previously, because it is calculated based on the global Composer install path. Or in other words: in this test scenario both paths differed, which can and will never happen in regular Composer based installations. relative prefix (which the hash is based on) before: /typo3temp/var/tests/functional-1c8f27c/typo3/sysext/rte_ckeditor/ after: /typo3/sysext/rte_ckeditor/ -
core-ci voted on patch set 3 V +1 09/18/25, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85130
-
Garvin Hicking commented on patch set 4
V +109/18/25, 20:44Published edit on patch set 3. -
Garvin Hicking commented on patch set 4 CR +1 V +1 09/18/25, 20:45
RichTextElementTest.php:66ReplyThanks so much for this insight :) -
Helmut Hummel commented on patch set 4 09/18/25, 20:49
RichTextElementTest.php:66ReplyThanks so much for the doc fix and the review! Very valid question that was. -
core-ci voted on patch set 4 V +1 09/18/25, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85132
-
Benni Mack voted on patch set 4 CR +1 V +1 09/19/25, 06:09
-
Oliver Klee voted on patch set 4 CR +1 V +1 09/19/25, 06:35
-
Helmut Hummel commented on patch set 4 CR +2 V +2 09/19/25, 06:45
Thanks! -
Helmut Hummel merged patch set 5 09/19/25, 06:45
Breaking-107482-EnvironmentGetComposerRootPathMethodsRemoved.rst:6