Review main Abandoned

90718[TASK] Update Feature-91499-AdditionalAttributesForIncludeJSIncludeCSSAndA

TYPO3com CR -1 V -1 Easy +11 −6 updated 09/22/25, 17:14

Commit message

…OtherInclude.rst

Fixed an error in Attributes-Examples. Data-Attribute needs a
*data."-Part.

E.g.
someIncludeFile.data.data-foo
instead of (as documentated)
someincludeFile.data-foo

Review

  • Code review CR -1
    • Chris Müller -1
  • Verified V -1
    • Chris Müller -1
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. TYPO3com uploaded patch set 1 09/18/25, 18:52

  2. core-ci voted on patch set 1 V +1 09/18/25, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85126

  3. Chris Müller commented on patch set 1 CR -1 V -1 09/19/25, 15:06

    "someIncludeFile.data-foo" is clearly correct (looked into the PageRenderer and tested manually). Why do you think, the current documentation is wrong?
  4. Oli Bartsch commented on patch set 1 09/22/25, 17:13

    Reply Unresolved

    Using the proposed syntax actually leads to: PHP Warning: Array to string conversion in /var/www/html/typo3/sysext/core/Classes/Utility/GeneralUtility.php line 1000
  5. Oli Bartsch abandoned the change 09/22/25, 17:14

    This change is factually incorrect; see the comments.