Review main Merged

90722[BUGFIX] Respect admPanel.override in ViewHelperResolver

Stefan Froemken CR +2 V +2 Easy +6 −1 updated 12/18/25, 13:21

Commit message

The UserTSConfig option
`admPanel.override.preview.showFluidDebug`
was not respected in the `ViewHelperResolver`. Until now,
Fluid's debug namespace was only added if
`$BE_USER->uc['AdminPanel']['preview_showFluidDebug']`
was set, ignoring the override configuration from
UserTSConfig.

This leads to inconsistent behavior, since the Admin
Panel configuration service already evaluates
`admPanel.override` first before falling back
to `uc`. As a result, non-admin users could still
get the Fluid debug namespace enabled even if
`override.preview.showFluidDebug = 0` was set.

This patch aligns the behavior of
`ViewHelperResolver` with the Admin Panel
configuration service by also checking for
`admPanel.override.preview.showFluidDebug`
in UserTSConfig.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Benni Mack +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Stefan Froemken uploaded patch set 1 09/18/25, 21:19

  2. core-ci voted on patch set 1 V +1 09/18/25, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85134

  3. Benni Mack voted on patch set 1 CR +1 V +1 09/24/25, 16:01

  4. Simon Praetorius voted on patch set 1 CR +2 V +2 12/15/25, 16:32

  5. Simon Praetorius merged patch set 2 12/15/25, 16:40

  6. Christian Kuhn commented on patch set 2 12/18/25, 12:20

    ViewHelperResolver.php:136

    why public?

    ViewHelperResolver.php:138

    since getBackendUser() can return null, shouldn't this be '$this->getBackendUser()?->...' ?
  7. Simon Praetorius commented on patch set 2 12/18/25, 13:21

  8. Simon Praetorius commented on patch set 2 12/18/25, 13:21

    ViewHelperResolver.php:136 Reply

    Acknowledged

    ViewHelperResolver.php:138 Reply

    Acknowledged