Review main Merged

90725[BUGFIX] Fix full return type for TranslateElementPropertyViewHelper

Garvin Hicking CR +2 V +2 Easy +2 −2 updated 09/19/25, 11:49

Commit message

The return type adjustment in #107485 missed aligning the return
type of `TranslateElementPropertyViewHelper`, which passes the
return of `translationService->translateFormElementValue`. That
has 'null' as a possible outcome, which also needs to be the
return type of the `render()` method.

Unfortunately, this is not detected (covered?) by the level of our
phpstan tests because the `translateFormElementValue` has no
full return types, but only annotations, and these also missed
a `null` outcome.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Markus Klein +1
    • Simon Praetorius +1
    • Jörg Bösche +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Simon Praetorius +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 89

  1. Garvin Hicking uploaded patch set 1 09/19/25, 09:51

  2. core-ci voted on patch set 1 V +1 09/19/25, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85156

  3. Simon Praetorius voted on patch set 1 CR +1 V +1 09/19/25, 09:59

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/19/25, 10:08

  5. Oliver Klee voted on patch set 1 CR +1 V +1 09/19/25, 10:27

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 09/19/25, 10:33

  7. Markus Klein voted on patch set 1 CR +1 09/19/25, 11:18

  8. Jörg Bösche voted on patch set 1 CR +1 09/19/25, 11:27

  9. Christian Kuhn merged patch set 2 09/19/25, 11:49