Review 13.4 Merged

90729[BUGFIX] Allow form element identifier in email finisher overrides

Garvin Hicking CR +2 V +2 Normal +65 −8 updated 09/19/25, 12:02

Commit message

When using the EXT:form plugin as a content element, it's flexform
definition allows to override certain elements of the form config.

For example, the "Email to sender" finisher allows to specify
an email address, which FormEngine renders as "type: email". Thus,
this only allows to enter valid emails.

However, one main reason to use flexform overrides for the plugin is
to be able to insert form element references so that the "Email
to sender" plugin actually uses the input of a frontend form
to send the mail to, by inserting `{userMailto}` or something else
as the identifier.

Doing so prevented FormEngine validation to save the input because
it no longer matched an email.

Sadly, the "type: email" attribute is tightly bound to the EXT:form
backend GUI. If just set to "type: input" then the input of the backend
would no longer enforce only entering valid emails. EXT:form extracts
the flexform settings from the base YAML with a complex method
to provide editing a plugin instance's specific mail addresses
within FormEngine.

So a solution was needed that allowed to:

1) Require to enter only valid emails in EXT:form GUI
2) Allow to enter either a valid email in FormEngine flexform
overrides, or a `{...}` identifier reference.

This is now solved with a custom formeval implementing a check
for both syntaxes, and not storing invalid values.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Garvin Hicking commented on patch set 1 09/19/25, 11:48

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/19/25, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85167

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 09/19/25, 12:02

  4. Garvin Hicking merged patch set 2 09/19/25, 12:02