Review main Merged

90736[BUGFIX] Avoid double resolving of FlexForm data structure

Oli Bartsch CR +2 V +2 Easy +16 −16 updated 09/21/25, 19:30

Commit message

Previously, `FlexFormAjaxController` manually
resolved a flex form data structure based on
a given identifier and passed the result to the
`FormDataCompiler`. However, since the compiler
calls the form data providers — in particular
`TcaColumnsOverrides` — the manually resolved
structure was overwritten again. This caused
a logical error in `TcaFlexPrepare`.

The issue is now resolved by removing the manual
resolving in `FlexFormAjaxController`, as this
step is anyways handled by `TcaFlexPrepare`.

Besides fixing the bug, this also simplifies
the code and improves the overall flow.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 67

  1. Oli Bartsch uploaded patch set 1 09/19/25, 20:23

  2. core-ci voted on patch set 1 V +1 09/19/25, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85186

  3. Benni Mack voted on patch set 1 CR +1 V +1 09/19/25, 21:41

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/21/25, 09:00

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 09/21/25, 09:07

  6. Oli Bartsch voted on patch set 1 CR +2 V +2 09/21/25, 19:30

  7. Oli Bartsch merged patch set 2 09/21/25, 19:30