Review main Merged

90740[TASK] Remove further TSFE methods

Christian Kuhn CR +2 V +2 Normal +1 −76 updated 09/20/25, 14:25

Commit message

The entire class is marked @deprecated already, usages of
TypoScriptFrontendController and global TSFE are set up
to be detected by the extension scanner already. A final
ReST file will be added when the class is fully dissolved.

The patch removed a couple of methods that have no internal
usage:
- logDeprecatedTyposcript() could be copied in-place if needed
again
- set_no_cache() has a substitution via request attribute
- set_cache_timeout_default() unused and outdated

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 09/20/25, 13:16

  2. core-ci voted on patch set 1 V +1 09/20/25, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85209

  3. Benni Mack voted on patch set 1 CR +1 V +1 09/20/25, 13:29

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 09/20/25, 14:24

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 09/20/25, 14:25

  6. Christian Kuhn merged patch set 2 09/20/25, 14:25