90747[BUGFIX] Allow separate scrolling in new record wizard
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2532
Show 57 earlier messages
-
Christoph Brauer uploaded patch set 1 09/21/25, 13:00
-
core-ci voted on patch set 1 V -1 09/21/25, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85245
-
Christoph Brauer uploaded patch set 2
V -109/21/25, 18:37 -
core-ci voted on patch set 2 V +1 09/21/25, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85255
-
Oli Bartsch commented on patch set 2 09/21/25, 19:59
I like! This works great. Just for my understanding, what is the reason for the CSS change outside the webcompoent? -
Garvin Hicking commented on patch set 2 09/22/25, 06:19
Reply
If I understood correctly, the problem is that we need to affect the CSS of the "outer" modal, beyond the scope of the webcomponent that doesn't allow CSS changes of it affect the "outside". Which is why a selector is created to be able to affect this "outside". But maybe Christoph can explain it better, I only get half of this. -
Christoph Brauer commented on patch set 2 09/22/25, 07:26
Reply
Hey, yes, Garvin got that correctly. We need to remove the overflow-y: auto from the parent, in this case the ".modal-body" to allow both individual containers inside the modal to scroll themselves. Unfortunately there's no really beautiful way to achieve this with CSS only (at least i don't know any) so we had to go the other way around. But i figured, since the css in the modal.scss is clearly targeting one specific web-component, this should be totally fine.
-
Oli Bartsch commented on patch set 2 CR +1 V +1 09/22/25, 07:49
Reply
Alright, thanks for the explanation. Fine for me! -
Oli Bartsch updated the commit message in patch set 3
CR +1V +109/22/25, 07:50 -
Oli Bartsch voted on patch set 3 CR +1 V +1 09/22/25, 07:50
-
core-ci voted on patch set 3 V +1 09/22/25, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85279
-
Garvin Hicking commented on patch set 3 V +1 09/22/25, 08:05
I can't really judge the code implications, but it "works on my machine" -
Andreas Kienast commented on patch set 3 CR -1 09/22/25, 08:07
new-record-wizard.ts:747Why do we need this? AFAIK neither of these properties changes on runtime. -
Christoph Brauer commented on patch set 3 09/22/25, 09:28
It's a fair point. Even though everything in the modal disappears, if you filter for something that doesn't exist. But yes, i get the argument 😊 I will have a brief look into it tonight. -
Christoph Brauer uploaded patch set 4
CR +1V +109/22/25, 18:19 -
core-ci voted on patch set 4 V +1 09/22/25, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85333
-
Oli Bartsch commented on patch set 4 09/23/25, 07:30
Hi Christoph, thank you very much for the latest adjustments. Could you please update the commit message? Remove the WIP and add some more information about what this patch does technically? -
Christoph Brauer updated the commit message in patch set 5
V +109/23/25, 07:54 -
core-ci voted on patch set 5 V +1 09/23/25, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85369
-
Oli Bartsch commented on patch set 5 09/23/25, 08:49
Thanks! A final thing. The navigation does no longer show up on mobile (< 500px) viewports. Clicking the toggle button does not show the category tablist anymore. -
Christoph Brauer uploaded patch set 6
V +109/23/25, 09:05 -
Christoph Brauer commented on patch set 6 09/23/25, 09:06
Reply
Ah, sorry. This was fixed in the latest patchset. -
core-ci voted on patch set 6 V +1 09/23/25, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85375
-
Oli Bartsch commented on patch set 6 09/23/25, 12:45
Reply
I see. Final question. Would it be possible o have the dropdown scrollable in mobile viewport. Current patchset needs the whole modal to be scrolled to get to the bottom categories. -
Christoph Brauer commented on patch set 6 09/23/25, 16:38
Reply
The dropdown is absolutely positioned, so it has no knowledge of any overflows or heights of its surrounding elements. I'm afraid this is something, that won't be possible (without fundamental markup changes 😊) -
Andreas Kienast commented on patch set 6 09/24/25, 05:51
new-record-wizard.ts:747ReplyDone -
Garvin Hicking updated the commit message in patch set 7
CR +1V +109/24/25, 06:29 -
Garvin Hicking voted on patch set 7 CR +1 V +1 09/24/25, 06:29
-
core-ci voted on patch set 7 V +1 09/24/25, 06:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85425
-
Oli Bartsch voted on patch set 7 CR +2 V +2 09/24/25, 07:26
-
Oli Bartsch merged patch set 8 09/24/25, 07:42