Review main Merged

90747[BUGFIX] Allow separate scrolling in new record wizard

Christoph Brauer CR +2 V +2 Easy +27 −1 updated 09/24/25, 07:42

Commit message

The "New record" wizard modal popup has separate navigation
and content panes which previously scrolled in conjunction with
each other.

This patch now allows distinct scrolling in both areas, so the
contents of the selected navigation pane item can remain visible.

This is done by using a reflected property in the new record wizard
web component on-build, which is sent to its parent, so it can be
determined by the parent if the child has a navigation element. If
so, the parent can be set to overflow: hidden to allow the
navigation and the content to get individual overflow values.

Since it is timed in the willUpdate-Hook, this will also work correctly, if any events trigger on runtime. This can be beneficial in future
updates for events like this.

The mobile handling (which shows a dropdown instead of a navigation
pane) remains unaffected.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2532

Show 57 earlier messages
  1. Christoph Brauer uploaded patch set 1 09/21/25, 13:00

  2. core-ci voted on patch set 1 V -1 09/21/25, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85245

  3. Christoph Brauer uploaded patch set 2 V -1 09/21/25, 18:37

  4. core-ci voted on patch set 2 V +1 09/21/25, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85255

  5. Oli Bartsch commented on patch set 2 09/21/25, 19:59

    I like! This works great. Just for my understanding, what is the reason for the CSS change outside the webcompoent?
  6. Garvin Hicking commented on patch set 2 09/22/25, 06:19

    Reply

    If I understood correctly, the problem is that we need to affect the CSS of the "outer" modal, beyond the scope of the webcomponent that doesn't allow CSS changes of it affect the "outside". Which is why a selector is created to be able to affect this "outside". But maybe Christoph can explain it better, I only get half of this.
  7. Christoph Brauer commented on patch set 2 09/22/25, 07:26

    Reply

    Hey, yes, Garvin got that correctly. We need to remove the overflow-y: auto from the parent, in this case the ".modal-body" to allow both individual containers inside the modal to scroll themselves. Unfortunately there's no really beautiful way to achieve this with CSS only (at least i don't know any) so we had to go the other way around. But i figured, since the css in the modal.scss is clearly targeting one specific web-component, this should be totally fine.
  1. Oli Bartsch commented on patch set 2 CR +1 V +1 09/22/25, 07:49

    Reply

    Alright, thanks for the explanation. Fine for me!
  2. Oli Bartsch updated the commit message in patch set 3 CR +1 V +1 09/22/25, 07:50

  3. Oli Bartsch voted on patch set 3 CR +1 V +1 09/22/25, 07:50

  4. core-ci voted on patch set 3 V +1 09/22/25, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85279

  5. Garvin Hicking commented on patch set 3 V +1 09/22/25, 08:05

    I can't really judge the code implications, but it "works on my machine"
  6. Andreas Kienast commented on patch set 3 CR -1 09/22/25, 08:07

    new-record-wizard.ts:747

    Why do we need this? AFAIK neither of these properties changes on runtime.
  7. Christoph Brauer commented on patch set 3 09/22/25, 09:28

    It's a fair point. Even though everything in the modal disappears, if you filter for something that doesn't exist. But yes, i get the argument 😊 I will have a brief look into it tonight.
  8. Christoph Brauer uploaded patch set 4 CR +1 V +1 09/22/25, 18:19

  9. core-ci voted on patch set 4 V +1 09/22/25, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85333

  10. Oli Bartsch commented on patch set 4 09/23/25, 07:30

    Hi Christoph, thank you very much for the latest adjustments. Could you please update the commit message? Remove the WIP and add some more information about what this patch does technically?
  11. Christoph Brauer updated the commit message in patch set 5 V +1 09/23/25, 07:54

  12. core-ci voted on patch set 5 V +1 09/23/25, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85369

  13. Oli Bartsch commented on patch set 5 09/23/25, 08:49

    Thanks! A final thing. The navigation does no longer show up on mobile (< 500px) viewports. Clicking the toggle button does not show the category tablist anymore.
  14. Christoph Brauer uploaded patch set 6 V +1 09/23/25, 09:05

  15. Christoph Brauer commented on patch set 6 09/23/25, 09:06

    Reply

    Ah, sorry. This was fixed in the latest patchset.
  16. core-ci voted on patch set 6 V +1 09/23/25, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85375

  17. Oli Bartsch commented on patch set 6 09/23/25, 12:45

    Reply

    I see. Final question. Would it be possible o have the dropdown scrollable in mobile viewport. Current patchset needs the whole modal to be scrolled to get to the bottom categories.
  18. Christoph Brauer commented on patch set 6 09/23/25, 16:38

    Reply

    The dropdown is absolutely positioned, so it has no knowledge of any overflows or heights of its surrounding elements. I'm afraid this is something, that won't be possible (without fundamental markup changes 😊)
  19. Oli Bartsch commented on patch set 6 CR +1 V +1 09/23/25, 17:24

    Reply

    Done

    Reply

    Acknowledged
  20. Andreas Kienast commented on patch set 6 09/24/25, 05:51

    new-record-wizard.ts:747 Reply

    Done
  21. Garvin Hicking updated the commit message in patch set 7 CR +1 V +1 09/24/25, 06:29

  22. Garvin Hicking voted on patch set 7 CR +1 V +1 09/24/25, 06:29

  23. core-ci voted on patch set 7 V +1 09/24/25, 06:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85425

  24. Oli Bartsch voted on patch set 7 CR +2 V +2 09/24/25, 07:26

  25. Oli Bartsch merged patch set 8 09/24/25, 07:42