Review main Merged

90748[DOCS] Consolidate finisher documentation

Lina Wolf CR +2 V +2 Expert +1065 −1398 updated 10/03/25, 18:07

Commit message

Information about finishers was previously spread across three
locations:

* https://docs.typo3.org/permalink/typo3-cms-form:finishers
* https://docs.typo3.org/permalink/typo3-cms-form:concepts-finishers
* https://docs.typo3.org/permalink/typo3-cms-form:apireference-finisheroptions

Each of these sections repeated the description of every finisher and
its options.

The descriptions have now been merged into a single location. Content
relevant for editors is presented first, followed by usage in YAML, and
lastly how to use finishers programmatically. This way, all information
on a finisher is available in one place.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 27

Show 7 more files

Review log 2023

  1. Lina Wolf uploaded patch set 1 09/21/25, 14:00

  2. Lina Wolf commented on patch set 1 09/21/25, 14:04

    I also prepared a PR to redirect the removed page: https://github.com/TYPO3GmbH/site-intercept/pull/236
  3. core-ci voted on patch set 1 V +1 09/21/25, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85246

  4. Garvin Hicking commented on patch set 1 09/22/25, 06:35

    Index.rst:19

    ```suggestion is now described in: `Ready-to-use finishers <https://docs.typo3.org/permalink/typo3/cms-form:apireference-finisheroptions>`_. ``` :-D
  5. Lina Wolf commented on patch set 1 09/22/25, 06:37

    Index.rst:19 Reply

    Fix applied.
  6. Garvin Hicking voted on patch set 1 CR +1 V +1 09/22/25, 08:18

  7. Josua Vogel commented on patch set 1 09/22/25, 13:01

    The content is now displayed in the “For Integrators” section, which I think is misleading. I think it would be better to have the "Concepts" folder at the top level with the “Finisher” subpage.
  8. Josua Vogel commented on patch set 1 09/22/25, 13:02

    Reply

    unresolved
  9. Josua Vogel rebased onto patch set 2 CR +1 V +1 09/22/25, 13:08

  10. Lina Wolf commented on patch set 2 09/22/25, 13:12

    Reply

    I would like to get rid of these For integrators etc direcotries, however that would mean moving a lot of pages around, so I think that is something we should do in a separate commit
  11. core-ci voted on patch set 2 V +1 09/22/25, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85299

  12. Josua Vogel commented on patch set 2 09/22/25, 13:17

    Reply

    Okay, but that should we do soon. It could be hard for a developer to find the parts he needs inside the integrators section 😊
  13. Josua Vogel voted on patch set 2 CR +1 V +1 09/22/25, 13:17

  14. Lina Wolf commented on patch set 2 09/22/25, 13:19

    Reply

    I left hints in both the developer and the integration section about where the content was moved.
  15. Garvin Hicking uploaded patch set 3 CR +1 V +1 09/24/25, 06:46

  16. Garvin Hicking commented on patch set 3 09/24/25, 06:47

    Index.rst:60

    I could not find this helpful section for editors here anymore, which describes how to use/find variables and what the input fields are. Was this intentionally removed, or is missing?
  17. core-ci voted on patch set 3 V +1 09/24/25, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85426

  18. Lina Wolf commented on patch set 3 10/03/25, 09:34

    Index.rst:60 Reply

    Each option is described with the finishers options. They are devided into those that can be set via GUI by editors and those that can be set via YAMl or programatically only
  19. Josua Vogel voted on patch set 3 CR +1 V +1 10/03/25, 10:55

  20. Garvin Hicking voted on patch set 3 CR +2 V +2 10/03/25, 11:13

  21. Garvin Hicking commented on patch set 3 CR +1 V +1 10/03/25, 16:19

    (backport needs conflict resolving, need some time)
  22. Garvin Hicking commented on patch set 3 CR +2 V +2 10/03/25, 18:07

    Reply

    Done
  23. Garvin Hicking merged patch set 4 10/03/25, 18:07