90748[DOCS] Consolidate finisher documentation
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Josua Vogel +1
-
Verified V +2 Done
- Garvin Hicking +2
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 27
- typo3/sysext/form/Documentation/D/FinisherOptions/Index.rstdeleted+0 −1228
- typo3/sysext/form/Documentation/D/Index.rst2+10 −9
- typo3/sysext/form/Documentation/E/Finishers/Index.rst2+19 −155
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/ClosureFinisher/_codesnippets/_finisher.php.incnew+20 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/ClosureFinisher/Index.rst+33 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/ConfirmationFinisher/_codesnippets/_finisher.php.incnew+18 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/ConfirmationFinisher/_codesnippets/_form_with_confirmation_content_element.yamlnew+10 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/ConfirmationFinisher/_codesnippets/_form_with_confirmation_finisher.yamlnew+10 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/ConfirmationFinisher/Index.rst+58 −2
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/DeleteUploadsFinisher/_codesnippets/_finisher.php.incnew+12 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/DeleteUploadsFinisher/_codesnippets/_form.yamlnew+13 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/DeleteUploadsFinisher/Index.rst+29 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/EmailFinisher/_codesnippets/_finisher.php.incnew+20 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/EmailFinisher/_codesnippets/_form.yamlnew+14 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/EmailFinisher/Index.rst+247 −1
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/FlashMessageFinisher/_codesnippets/_finisher.php.incnew+12 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/FlashMessageFinisher/_codesnippets/_form.yamlnew+28 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/FlashMessageFinisher/Index.rst+85 −1
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/RedirectFinisher/_codesnippets/_finisher.php.incnew+15 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/RedirectFinisher/_codesnippets/_form.yamlnew+10 −0
Show 7 more files
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/RedirectFinisher/Index.rst+93 −2
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/SaveToDatabaseFinisher/_codesnippets/_finisher-multiple.php.incnew+30 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/SaveToDatabaseFinisher/_codesnippets/_finisher.php.incnew+31 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/SaveToDatabaseFinisher/_codesnippets/_form-multiple.yamlnew+22 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/SaveToDatabaseFinisher/_codesnippets/_form.yamlnew+14 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/SaveToDatabaseFinisher/Index.rst+211 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/Index.rst+1 −0
Review log 2023
-
Lina Wolf uploaded patch set 1 09/21/25, 14:00
-
Lina Wolf commented on patch set 1 09/21/25, 14:04
I also prepared a PR to redirect the removed page: https://github.com/TYPO3GmbH/site-intercept/pull/236 -
core-ci voted on patch set 1 V +1 09/21/25, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85246
-
Garvin Hicking commented on patch set 1 09/22/25, 06:35
Index.rst:19```suggestion is now described in: `Ready-to-use finishers <https://docs.typo3.org/permalink/typo3/cms-form:apireference-finisheroptions>`_. ``` :-D -
Lina Wolf commented on patch set 1 09/22/25, 06:37
Index.rst:19ReplyFix applied. -
Garvin Hicking voted on patch set 1 CR +1 V +1 09/22/25, 08:18
-
Josua Vogel commented on patch set 1 09/22/25, 13:01
The content is now displayed in the “For Integrators” section, which I think is misleading. I think it would be better to have the "Concepts" folder at the top level with the “Finisher” subpage. -
Josua Vogel commented on patch set 1 09/22/25, 13:02
Reply
unresolved -
Josua Vogel rebased onto patch set 2
CR +1V +109/22/25, 13:08 -
Lina Wolf commented on patch set 2 09/22/25, 13:12
Reply
I would like to get rid of these For integrators etc direcotries, however that would mean moving a lot of pages around, so I think that is something we should do in a separate commit -
core-ci voted on patch set 2 V +1 09/22/25, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85299
-
Josua Vogel commented on patch set 2 09/22/25, 13:17
Reply
Okay, but that should we do soon. It could be hard for a developer to find the parts he needs inside the integrators section 😊 -
Josua Vogel voted on patch set 2 CR +1 V +1 09/22/25, 13:17
-
Lina Wolf commented on patch set 2 09/22/25, 13:19
Reply
I left hints in both the developer and the integration section about where the content was moved. -
Garvin Hicking uploaded patch set 3
CR +1V +109/24/25, 06:46 -
Garvin Hicking commented on patch set 3 09/24/25, 06:47
Index.rst:60I could not find this helpful section for editors here anymore, which describes how to use/find variables and what the input fields are. Was this intentionally removed, or is missing? -
core-ci voted on patch set 3 V +1 09/24/25, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85426
-
Lina Wolf commented on patch set 3 10/03/25, 09:34
Index.rst:60ReplyEach option is described with the finishers options. They are devided into those that can be set via GUI by editors and those that can be set via YAMl or programatically only -
Josua Vogel voted on patch set 3 CR +1 V +1 10/03/25, 10:55
-
Garvin Hicking voted on patch set 3 CR +2 V +2 10/03/25, 11:13
-
Garvin Hicking commented on patch set 3 CR +1 V +1 10/03/25, 16:19
(backport needs conflict resolving, need some time) -
Garvin Hicking commented on patch set 3 CR +2 V +2 10/03/25, 18:07
Reply
Done -
Garvin Hicking merged patch set 4 10/03/25, 18:07