Review main Merged

90750[BUGFIX] Ensure correct module is bookmarked in acceptance tests

Oli Bartsch CR +2 V +2 Easy +4 −0 updated 09/22/25, 06:27

Commit message

By manually selecting the expected module, we
ensure the bookmarks test can be executed on
its own, without any cross dependencies.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2

Issues 2

Files 1

Review log 1013

  1. Oli Bartsch uploaded patch set 1 09/21/25, 19:44

  2. core-ci voted on patch set 1 V +1 09/21/25, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85256

  3. Thomas Hohn voted on patch set 1 CR +1 09/21/25, 19:52

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 09/21/25, 20:01

    lets try.
  5. core-ci voted on patch set 1 V -1 09/21/25, 20:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85258

  6. Garvin Hicking commented on patch set 1 09/21/25, 20:32

    The CI -1 is a tested nightly, which fails on phpstan max. This one is good to go.
  7. Benni Mack voted on patch set 1 CR +1 V +1 09/22/25, 05:50

  8. Stefan Bürk voted on patch set 1 CR +1 V +1 09/22/25, 06:06

  9. Garvin Hicking voted on patch set 1 CR +2 V +2 09/22/25, 06:08

  10. Oli Bartsch rebased onto patch set 2 CR +1 V +1 09/22/25, 06:20

  11. Garvin Hicking commented on patch set 2 CR +2 V +2 09/22/25, 06:21

    merging with prior votes, had to rebase.
  12. Garvin Hicking merged patch set 3 09/22/25, 06:21

  13. core-ci voted on patch set 2 V +1 09/22/25, 06:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85276