Review main Merged

90755[TASK] Remove "en" fallback in LocalizationFactory

Benni Mack CR +2 V +2 Normal +45 −100 updated 09/22/25, 18:28

Commit message

LocalizationFactory is now simplified.

It previously returned getParsedData() with the
language keys "en" and the given $languageKey
as an array of labels.

In addition, it used internal calls with runtime
caches, even though this is not needed anymore, mainly
because
1. XML overrides are now covered properly in system cache
2. consumer code ($GLOBALS[LANG]) fetched "en" separately
   already.
3. Runtime cache is already in the comsumer code.

This allows us to thin out LocalizationFactory,
removing the runtime cache in this class, making this
class effectively stateless.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 913

  1. Benni Mack uploaded patch set 1 09/22/25, 08:58

  2. core-ci voted on patch set 1 V -1 09/22/25, 09:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85281

  3. Benni Mack uploaded patch set 2 V -1 09/22/25, 10:45

  4. Benni Mack uploaded patch set 3 09/22/25, 10:57

  5. core-ci voted on patch set 2 V -1 09/22/25, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85288

  6. core-ci voted on patch set 3 V +1 09/22/25, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85291

  7. Benni Mack commented on patch set 4 V +1 09/22/25, 12:22

    Published edit on patch set 3.
  8. core-ci voted on patch set 4 V +1 09/22/25, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85296

  9. Garvin Hicking voted on patch set 4 CR +1 V +1 09/22/25, 15:27

  10. Oli Bartsch voted on patch set 4 CR +1 V +1 09/22/25, 16:19

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 09/22/25, 17:51

  12. Benni Mack voted on patch set 4 CR +2 V +2 09/22/25, 18:28

  13. Benni Mack merged patch set 5 09/22/25, 18:28