Review main Merged Breaking

90758[!!!][FEATURE] Add PSR-14 Event before renderable is added to form

Josua Vogel CR +2 V +2 Hard +232 −64 updated 09/24/25, 08:39

Commit message

A new PSR-14 event TYPO3\CMS\Form\Event\BeforeRenderableIsAddedToFormEvent
is introduced which serves as an improved replacement for the now
removed hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/form']
['initializeFormElement'].

The new event in comparison to the removed hook is dispatched
after the renderable has been initialized and right before
being added to its form.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1724

  1. Josua Vogel uploaded patch set 1 09/22/25, 11:29

  2. core-ci voted on patch set 1 V -1 09/22/25, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85293

  3. Josua Vogel uploaded patch set 2 V -1 09/22/25, 12:12

  4. core-ci voted on patch set 2 V -1 09/22/25, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85295

  5. Josua Vogel uploaded patch set 3 V -1 09/22/25, 12:39

  6. core-ci voted on patch set 3 V +1 09/22/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85297

  7. Chris Müller commented on patch set 3 09/22/25, 13:20

    Feature-107518-IntroducePSR14AfterFormElementInitializedEvent.rst:20

    it's -> its
  8. Josua Vogel commented on patch set 4 V +1 09/22/25, 13:23

    Published edit on patch set 3.
  9. Josua Vogel commented on patch set 4 09/22/25, 13:23

    Feature-107518-IntroducePSR14AfterFormElementInitializedEvent.rst:20 Reply

    Done
  10. core-ci voted on patch set 4 V +1 09/22/25, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85301

  11. Georg Ringer voted on patch set 4 CR +1 V +1 09/22/25, 14:07

  12. Oli Bartsch commented on patch set 4 V -1 09/22/25, 16:47

    I can not really get the benefit of the event. Whatever I apply to the renderable is overwritten again in `ArrayFormFactory->addNestedRenderable()`. Maybe I do miss sth.?
  13. Josua Vogel uploaded patch set 5 CR +1 V +1 09/23/25, 11:53

  14. Josua Vogel commented on patch set 5 09/23/25, 11:56

    Reply

    I changed the location of the event. Now it´s possible to modify the renderable without being overwritten.
  15. core-ci voted on patch set 5 V +1 09/23/25, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85380

  16. Josua Vogel updated the commit message in patch set 6 V +1 09/23/25, 12:04

  17. core-ci voted on patch set 6 V +1 09/23/25, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85381

  18. Oli Bartsch uploaded patch set 7 V +1 09/23/25, 18:54

  19. core-ci voted on patch set 7 V +1 09/23/25, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85404

  20. Oli Bartsch voted on patch set 7 CR +1 V +1 09/23/25, 19:24

  21. Garvin Hicking commented on patch set 7 09/24/25, 08:26

    Breaking-107518-RemovedInitializeFormElementHook.rst:40

    Could you maybe add a (simple) code example on how an existing hook implementation could be replaced to the new event?
  22. Garvin Hicking commented on patch set 7 CR +1 V +1 09/24/25, 08:35

    Breaking-107518-RemovedInitializeFormElementHook.rst:40 Reply

    OK never mind. Seems none of our breaking changes for hook replacements specify code for this, then I won't break that habbit, sorry!
  23. Oli Bartsch voted on patch set 7 CR +2 V +2 09/24/25, 08:38

  24. Oli Bartsch merged patch set 8 09/24/25, 08:39