90758[!!!][FEATURE] Add PSR-14 Event before renderable is added to form
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107518-RemovedInitializeFormElementHook.rst2new+41 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107518-IntroducePSR14BeforeRenderableIsAddedToFormEvent.rstnew+52 −0
- typo3/sysext/form/Classes/Domain/Factory/ArrayFormFactory.php+7 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractFormElement.php+1 −12
- typo3/sysext/form/Classes/Domain/Model/FormElements/Date.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/DatePicker.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/FileUpload.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/Section.php+1 −12
- typo3/sysext/form/Classes/Domain/Model/FormElements/UnknownFormElement.php+1 −12
- typo3/sysext/form/Classes/Event/BeforeRenderableIsAddedToFormEvent.phpnew+30 −0
- typo3/sysext/form/Tests/Functional/Domain/Factory/ArrayFormFactoryTest.phpnew+90 −0
- typo3/sysext/form/Tests/Unit/Domain/Factory/ArrayFormFactoryTest.php+3 −2
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractFormElementTest.php+0 −22
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+6 −0
Review log 1724
-
Josua Vogel uploaded patch set 1 09/22/25, 11:29
-
core-ci voted on patch set 1 V -1 09/22/25, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85293
-
Josua Vogel uploaded patch set 2
V -109/22/25, 12:12 -
core-ci voted on patch set 2 V -1 09/22/25, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85295
-
Josua Vogel uploaded patch set 3
V -109/22/25, 12:39 -
core-ci voted on patch set 3 V +1 09/22/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85297
-
Chris Müller commented on patch set 3 09/22/25, 13:20
-
Josua Vogel commented on patch set 4
V +109/22/25, 13:23Published edit on patch set 3. -
Josua Vogel commented on patch set 4 09/22/25, 13:23
Feature-107518-IntroducePSR14AfterFormElementInitializedEvent.rst:20ReplyDone -
core-ci voted on patch set 4 V +1 09/22/25, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85301
-
Georg Ringer voted on patch set 4 CR +1 V +1 09/22/25, 14:07
-
Oli Bartsch commented on patch set 4 V -1 09/22/25, 16:47
I can not really get the benefit of the event. Whatever I apply to the renderable is overwritten again in `ArrayFormFactory->addNestedRenderable()`. Maybe I do miss sth.? -
Josua Vogel uploaded patch set 5
CR +1V +109/23/25, 11:53 -
Josua Vogel commented on patch set 5 09/23/25, 11:56
Reply
I changed the location of the event. Now it´s possible to modify the renderable without being overwritten. -
core-ci voted on patch set 5 V +1 09/23/25, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85380
-
Josua Vogel updated the commit message in patch set 6
V +109/23/25, 12:04 -
core-ci voted on patch set 6 V +1 09/23/25, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85381
-
Oli Bartsch uploaded patch set 7
V +109/23/25, 18:54 -
core-ci voted on patch set 7 V +1 09/23/25, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85404
-
Oli Bartsch voted on patch set 7 CR +1 V +1 09/23/25, 19:24
-
Garvin Hicking commented on patch set 7 09/24/25, 08:26
Breaking-107518-RemovedInitializeFormElementHook.rst:40Could you maybe add a (simple) code example on how an existing hook implementation could be replaced to the new event? -
Garvin Hicking commented on patch set 7 CR +1 V +1 09/24/25, 08:35
Breaking-107518-RemovedInitializeFormElementHook.rst:40ReplyOK never mind. Seems none of our breaking changes for hook replacements specify code for this, then I won't break that habbit, sorry! -
Oli Bartsch voted on patch set 7 CR +2 V +2 09/24/25, 08:38
-
Oli Bartsch merged patch set 8 09/24/25, 08:39
Feature-107518-IntroducePSR14AfterFormElementInitializedEvent.rst:20