Review main Merged

90759[DOCS] Correct permalinks in EXT:form

Lina Wolf CR +2 V +2 Normal +31 −31 updated 09/26/25, 23:32

Commit message

Unfortunately, the docs.typo3.org permalink modal used a wrong
composer-based URI pattern like:

  `https://docs.typo3.org/permalink/typo3/cms-seo:installation`

which used a forward slash. The actual permalink tool could
however only resolve links like:

  `https://docs.typo3.org/permalink/typo3-cms-seo:installation`

(note the `typo3/` vs. `typo3-` notation).

This patch uses the canonical dash notation now. Meanwhile,
the permalink tool has been changed to also accept the
slash notation for compatibility.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1620

  1. Lina Wolf uploaded patch set 1 09/22/25, 14:23

  2. Georg Ringer updated the commit message in patch set 2 09/22/25, 14:26

  3. Georg Ringer voted on patch set 2 CR +1 V +1 09/22/25, 14:26

  4. core-ci voted on patch set 1 V +1 09/22/25, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85304

  5. core-ci voted on patch set 2 V +1 09/22/25, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85305

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 09/22/25, 15:08

  7. Garvin Hicking commented on patch set 2 V 0 CR -1 09/22/25, 15:10

    There are more wrong permalinks: ``` typo3/sysext/core/Documentation/Changelog/14.0/Feature-106363-ModifyPagesForIntegrityCheck.rst:`redirects:checkintegrity <https://docs.typo3.org/permalink/typo3/cms-redirects:redirects-checkintegrity>`_. typo3/sysext/indexed_search/Documentation/BackendModule/Index.rst: `Trouble shooting: Backend module "Indexing" does not show <https://docs.typo3.org/permalink/typo3/cms-indexed-search:module-trouble-shooting>`_. typo3/sysext/indexed_search/Documentation/BackendModule/Index.rst:* Is indexed search `installed <https://docs.typo3.org/permalink/typo3/cms-indexed-search:installation>`_? typo3/sysext/indexed_search/Documentation/UserManual/Index.rst: `installed <https://docs.typo3.org/permalink/typo3/cms-indexed-search:installation>`_ typo3/sysext/indexed_search/Documentation/UserManual/Index.rst: `Site set "Indexed Search" <https://docs.typo3.org/permalink/typo3/cms-indexed-search:site-set>`_ typo3/sysext/indexed_search/Documentation/UserManual/Index.rst:`Monitoring indexed content <https://docs.typo3.org/permalink/typo3/cms-indexed-search:monitoring-indexed-content>`_. typo3/sysext/seo/Documentation/Features/Index.rst:After `Installation <https://docs.typo3.org/permalink/typo3/cms-seo:installation>`_ typo3/sysext/seo/Documentation/Features/Index.rst: `title tag <https://docs.typo3.org/permalink/typo3/cms-seo:seo-page-title-provider>`_ typo3/sysext/seo/Documentation/Features/Index.rst: `Canonical URL <https://docs.typo3.org/permalink/typo3/cms-seo:canonical-url>`_ typo3/sysext/seo/Documentation/Features/Index.rst: `XML Sitemap <https://docs.typo3.org/permalink/typo3/cms-seo:xml-sitemap>`_. typo3/sysext/seo/Documentation/Features/Index.rst:`Dashboard manual, permissions of widgets <https://docs.typo3.org/permalink/typo3/cms-dashboard:permission-handling-of-widgets>`_ typo3/sysext/seo/Documentation/Features/Index.rst:`typo3/seo-sitemap <https://docs.typo3.org/permalink/typo3/cms-seo:configuration-site-sets>`_, typo3/sysext/seo/Documentation/Features/Index.rst:See chapter `XML sitemap <https://docs.typo3.org/permalink/typo3/cms-seo:xmlsitemap>`_ typo3/sysext/seo/Documentation/Features/XmlSitemap.rst:included via `Site sets <https://docs.typo3.org/permalink/typo3/cms-seo:configuration-site-sets>`_ typo3/sysext/seo/Documentation/Introduction/Index.rst:`Features of the TYPO3 system extension "seo" <https://docs.typo3.org/permalink/typo3/cms-seo:features>`_. ```
  8. Garvin Hicking commented on patch set 2 09/22/25, 19:17

    Please check out https://github.com/TYPO3GmbH/site-intercept/pull/238 - if we merge this, we can leave the "wrong" links intact?
  9. Garvin Hicking commented on patch set 2 09/22/25, 19:17

    Reply

    unresolving

    Reply

    unreslving
  10. Garvin Hicking uploaded patch set 3 CR +1 V +1 09/24/25, 07:00

  11. Garvin Hicking commented on patch set 3 CR +1 V +1 09/24/25, 07:00

    The change to intercept for the permalink resolving was merged to allow both formats. I would suggest that we close/abandon this?

    Reply

    Done
  12. core-ci voted on patch set 3 V +1 09/24/25, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85428

  13. Garvin Hicking commented on patch set 3 09/24/25, 07:15

    Reply

    Done
  14. Oli Bartsch uploaded patch set 4 CR +1 V +1 09/25/25, 19:59

  15. Oli Bartsch voted on patch set 4 CR +1 V +1 09/25/25, 20:00

  16. Garvin Hicking voted on patch set 4 CR +1 V +1 09/25/25, 20:04

  17. core-ci voted on patch set 4 V +1 09/25/25, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85549

  18. Garvin Hicking voted on patch set 4 CR +2 V +2 09/26/25, 06:47

  19. Garvin Hicking merged patch set 5 09/26/25, 06:47

  20. Garvin Hicking wrote 09/26/25, 23:32

    Created a revert of this change as Ia818d91ecab7bc98da529bbc2dc6d5e0f811ae0b