90767[TASK] Remove internal methods in ResourceFactory
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 9
- Build/phpstan/phpstan-baseline.neon+0 −6
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+0 −60
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+0 −6
- typo3/sysext/core/Classes/Resource/StorageRepository.php+3 −2
- typo3/sysext/core/Documentation/Changelog/14.0/Important-107735-InternalMethodsRemovedFromResourceFactory.rstnew+48 −0
- typo3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php+0 −14
- typo3/sysext/extbase/Classes/Service/FileHandlingService.php+3 −1
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php+20 −27
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+28 −0
Review log 1217
-
Benni Mack uploaded patch set 1 09/22/25, 20:03
-
Benni Mack marked it work in progress 09/22/25, 20:05
-
core-ci voted on patch set 1 V -1 09/22/25, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85345
-
Benni Mack uploaded patch set 2
V -109/23/25, 05:52 -
core-ci voted on patch set 2 V +1 09/23/25, 05:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85363
-
Benni Mack updated the commit message in patch set 3
V +110/16/25, 19:24 -
Benni Mack marked it ready for review 10/16/25, 19:24
-
Benni Mack rebased onto patch set 4 10/16/25, 19:24
-
core-ci voted on patch set 3 V -1 10/16/25, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86837
-
core-ci voted on patch set 4 V +1 10/16/25, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86838
-
Garvin Hicking commented on patch set 4 10/16/25, 20:22
Would you be open to a "important" rst file (not breaking)? Because I know a few private extensions that used the convenience methods here and that would allow me to point toward a documentation file instead of a commit... 🫣 -
Benni Mack uploaded patch set 5
V +110/17/25, 06:55 -
Garvin Hicking commented on patch set 5 CR +1 V +1 10/17/25, 06:57
Thanks so much :) -
core-ci voted on patch set 5 V +1 10/17/25, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86867
-
Oliver Klee voted on patch set 5 CR +1 V +1 10/17/25, 08:01
-
Benni Mack voted on patch set 5 CR +2 V +2 10/17/25, 08:49
-
Benni Mack merged patch set 6 10/17/25, 08:49