Review main Merged

90767[TASK] Remove internal methods in ResourceFactory

Benni Mack CR +2 V +2 Normal +102 −116 updated 10/17/25, 08:49

Commit message

The following internal methods have been removed from ResourceFactory:
- getDefaultStorage(): Delegated to StorageRepository
- getStorageObject(): Delegated to StorageRepository
- createFolderObject(): Direct ResourceStorage access recommended
- getFileObjectByStorageAndIdentifier(): Delegated to StorageRepository

These methods were marked as @internal and are replaced by
using StorageRepository directly for better separation of concerns.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1217

  1. Benni Mack uploaded patch set 1 09/22/25, 20:03

  2. Benni Mack marked it work in progress 09/22/25, 20:05

  3. core-ci voted on patch set 1 V -1 09/22/25, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85345

  4. Benni Mack uploaded patch set 2 V -1 09/23/25, 05:52

  5. core-ci voted on patch set 2 V +1 09/23/25, 05:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85363

  6. Benni Mack updated the commit message in patch set 3 V +1 10/16/25, 19:24

  7. Benni Mack marked it ready for review 10/16/25, 19:24

  8. Benni Mack rebased onto patch set 4 10/16/25, 19:24

  9. core-ci voted on patch set 3 V -1 10/16/25, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86837

  10. core-ci voted on patch set 4 V +1 10/16/25, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86838

  11. Garvin Hicking commented on patch set 4 10/16/25, 20:22

    Would you be open to a "important" rst file (not breaking)? Because I know a few private extensions that used the convenience methods here and that would allow me to point toward a documentation file instead of a commit... 🫣
  12. Benni Mack uploaded patch set 5 V +1 10/17/25, 06:55

  13. Garvin Hicking commented on patch set 5 CR +1 V +1 10/17/25, 06:57

    Thanks so much :)
  14. core-ci voted on patch set 5 V +1 10/17/25, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86867

  15. Oliver Klee voted on patch set 5 CR +1 V +1 10/17/25, 08:01

  16. Benni Mack voted on patch set 5 CR +2 V +2 10/17/25, 08:49

  17. Benni Mack merged patch set 6 10/17/25, 08:49