Review main Merged Breaking

90778[!!!][FEATURE] Add PSR-14 Event before renderable removed

Josua Vogel CR +2 V +2 Normal +188 −7 updated 09/25/25, 20:17

Commit message

A new PSR-14 event TYPO3\CMS\Form\Event\BeforeRenderableIsRemovedFromFormEvent
has been introduced which serves as an improved replacement for the
now removed hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/form']['beforeRemoveFromParentRenderable'].

The new event is stoppable. Listeners can therefore
stop deletion as well as any other listener from
being called.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1217

  1. Josua Vogel uploaded patch set 1 09/23/25, 18:35

  2. Josua Vogel uploaded patch set 2 09/23/25, 18:40

  3. core-ci voted on patch set 1 V +1 09/23/25, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85402

  4. core-ci voted on patch set 2 V +1 09/23/25, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85403

  5. Josua Vogel uploaded patch set 3 V +1 09/24/25, 09:02

  6. core-ci voted on patch set 3 V +1 09/24/25, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85438

  7. Oli Bartsch uploaded patch set 4 V +1 09/25/25, 19:56

  8. Oli Bartsch voted on patch set 4 CR +1 V +1 09/25/25, 19:56

  9. Garvin Hicking commented on patch set 4 09/25/25, 20:01

    Breaking-107528-RemovedBeforeRemoveFromParentRenderableHook.rst:25

    ```suggestion TYPO3 installations with custom extensions using this hook. The extension ```

    Feature-107528-IntroducePSR14BeforeRenderableIsRemovedFromFormEvent.rst:28

    ```suggestion :php:`true`, no further listener gets called. ```

    BeforeRenderableIsRemovedFromFormEvent.php:33

    ```suggestion public bool $preventRemoval = false, ```
  10. Garvin Hicking commented on patch set 4 CR +1 V +1 09/25/25, 20:02

    Breaking-107528-RemovedBeforeRemoveFromParentRenderableHook.rst:25 Reply

    Fix applied.

    Feature-107528-IntroducePSR14BeforeRenderableIsRemovedFromFormEvent.rst:28 Reply

    Fix applied.

    BeforeRenderableIsRemovedFromFormEvent.php:33 Reply

    Fix applied.
  11. Garvin Hicking commented on patch set 5 CR +1 V +1 09/25/25, 20:02

    Published edit on patch set 4.
  12. Garvin Hicking voted on patch set 5 CR +1 V +1 09/25/25, 20:02

  13. core-ci voted on patch set 4 V +1 09/25/25, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85548

  14. Oli Bartsch voted on patch set 5 CR +1 V +1 09/25/25, 20:04

  15. core-ci voted on patch set 5 V +1 09/25/25, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85550

  16. Oli Bartsch voted on patch set 5 CR +2 V +2 09/25/25, 20:17

  17. Oli Bartsch merged patch set 6 09/25/25, 20:17