Review main Abandoned

90779[TASK] LocalCropScaleMaskHelper can optionally always create images

C. Gogolin CR 0 V -1 Hard +217 −90 updated 09/26/25, 10:32

Commit message

Adjusting the LocalCropScaleMaskHelper class ensures the helper
always produces images. This is useful when you want to create
a custom image-processing task, retain the LocalImageProcessor’s
standard functionality, but always require images for further
processing.

In addition to the option to force the helper to always generate
images, the ability to execute processors in a chain has been added.
This allows pre-processors to force image generation and a
post-processor to perform touch-ups at the end.

Each processor can decide whether there may be another processor
after it. Existing processor implementations do not explicitly
indicate that someone may follow them. Thus the chain is immediately
terminated after them, preserving the previous behavior.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 11

Review log 59

  1. C. Gogolin uploaded patch set 1 09/23/25, 20:06

  2. C. Gogolin uploaded patch set 2 09/23/25, 20:11

  3. C. Gogolin uploaded patch set 3 09/23/25, 20:12

  4. C. Gogolin uploaded patch set 4 09/23/25, 20:14

  5. core-ci voted on patch set 1 V -1 09/23/25, 20:17 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85406

  6. core-ci voted on patch set 3 V -1 09/23/25, 20:22 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 4 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85408

  7. core-ci voted on patch set 2 V -1 09/23/25, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85407

  8. core-ci voted on patch set 4 V -1 09/23/25, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85409

  9. Garvin Hicking abandoned the change 09/26/25, 10:32