Review main Merged

90782[BUGFIX] Consider starttime/endtime for versioned records

Benni Mack CR +2 V +2 Hard +318 −14 updated 01/20/26, 12:55

Commit message

The method PageRepository->checkIfPageIsHidden()
now considers if a page is visible / hidden, where
hidden also considers scheduled options (starttime/endtime)
instead of the plain "hidden" option.

This is mainly based on using "RecordAccessVoter"
instead of manual checking, allow for further
override possibilities.

Have a page in live with starttime in the future.
Go to workspace module, select that page, generate
preview links or preview side-by-side.

The main issue left is that the PreviewSimulator
does set a new VisibilityAspect now but does
not evaluate "includeScheduledRecords". We should
actually use a RecordAccessVoter->isRecordScheduled($table, $row)
method instead in the future once we have the full row.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 2845

Show 1020 earlier messages
  1. Benni Mack uploaded patch set 1 09/24/25, 07:44

  2. core-ci voted on patch set 1 V -1 09/24/25, 07:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85433

  3. Benni Mack uploaded patch set 2 V -1 09/24/25, 08:17

  4. core-ci voted on patch set 2 V -1 09/24/25, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85435

  5. Benni Mack uploaded patch set 3 V -1 09/25/25, 20:26

  6. core-ci voted on patch set 3 V -1 09/25/25, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85551

  7. Benni Mack commented on patch set 4 V -1 09/25/25, 20:58

    Published edit on patch set 3.
  8. core-ci voted on patch set 4 V -1 09/25/25, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85552

  9. Benni Mack uploaded patch set 5 V -1 09/26/25, 07:28

  10. core-ci voted on patch set 5 V -1 09/26/25, 07:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85576

  11. Benni Mack uploaded patch set 6 V -1 10/09/25, 15:28

  12. core-ci voted on patch set 6 V -1 10/09/25, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86315

  13. Benni Mack uploaded patch set 7 V -1 10/09/25, 19:22

  14. core-ci voted on patch set 7 V -1 10/09/25, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86338

  15. Benni Mack uploaded patch set 8 V -1 10/09/25, 19:40

  16. core-ci voted on patch set 8 V -1 10/09/25, 19:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86339

  17. Benni Mack uploaded patch set 9 V -1 10/09/25, 20:04

  18. core-ci voted on patch set 9 V +1 10/09/25, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86340

  19. Benni Mack uploaded patch set 10 V +1 10/13/25, 12:55

  20. core-ci voted on patch set 10 V +1 10/13/25, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86542

  1. Benni Mack uploaded patch set 11 V +1 10/13/25, 15:26

  2. core-ci voted on patch set 11 V -1 10/13/25, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86560

  3. Benni Mack uploaded patch set 12 V -1 10/13/25, 15:48

  4. core-ci voted on patch set 12 V +1 10/13/25, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86564

  5. Georg Ringer commented on patch set 12 10/13/25, 18:52

    PageRepository.php:2068

    should we do a array_unique?
  6. Benni Mack commented on patch set 12 10/14/25, 06:38

    PageRepository.php:2068 Reply

    not worth it IMHO. in the end, RecordAccessVoter / UserAspect does an in_array() check - that's it.
  7. Christian Kuhn commented on patch set 12 10/15/25, 05:35

    PageRepository.php:2068 Reply

    yeah. hope its fine to keep as is.

    AbstractActionTestCase.php:456

    unused.
  8. Christian Kuhn commented on patch set 12 10/15/25, 05:38

    PageRepository starts to *really* bite us. it becomes more and more apparent this needs a major overhaul that is based on all related records (pages, page translations and overlays) being fetched exactly once and then having checks on them.
  9. Christian Kuhn uploaded patch set 13 V +1 10/15/25, 05:40

  10. Christian Kuhn commented on patch set 12 10/15/25, 05:41

    Reply

    this change does not help us structurally in any way, but i guess we'll have to pick it since it gives us a bugfix for a nasty details various people tried to fix already.

    AbstractActionTestCase.php:456 Reply

    Done
  11. Christian Kuhn voted on patch set 13 CR +1 V +1 10/15/25, 05:41

  12. core-ci voted on patch set 13 V -1 10/15/25, 05:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86675

  13. core-ci commented on patch set 13 10/15/25, 05:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86675

  14. Christian Kuhn rebased onto patch set 14 CR +1 V +1 10/15/25, 06:21

  15. core-ci voted on patch set 14 V -1 10/15/25, 06:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86676

  16. Christian Kuhn rebased onto patch set 15 V -1 10/15/25, 08:33

  17. Christian Kuhn voted on patch set 15 CR +1 V +1 10/15/25, 08:34

  18. Oli Bartsch updated the commit message in patch set 16 CR +1 V +1 10/15/25, 08:41

  19. Oli Bartsch voted on patch set 16 CR +1 V +1 10/15/25, 08:41

  20. core-ci voted on patch set 15 V +1 10/15/25, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86696

  21. core-ci voted on patch set 16 V +1 10/15/25, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86699

  22. Christian Kuhn voted on patch set 16 CR +1 V +1 10/15/25, 10:07

  23. Benni Mack voted on patch set 16 CR +2 V +2 10/15/25, 10:09

  24. Benni Mack merged patch set 17 10/15/25, 10:09

  25. Garvin Hicking wrote 01/20/26, 12:55

    Created a revert of this change as I3cb5a6baf7c8d420c79c2cd242b2a33b5276c357