90782[BUGFIX] Consider starttime/endtime for versioned records
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 10
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php3+27 −12
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/createPageAndContentAndHide.csvnew+30 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/showPageAndContentInTheFuture.csvnew+28 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/ActionTest.php+51 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesModify/DataSet/createPageAndContentAndHide.csvnew+37 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesModify/DataSet/showPageAndContentInTheFuture.csvnew+45 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesModify/ActionTest.php+55 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/AbstractActionTestCase.php2+21 −0
- typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php+16 −2
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+8 −0
Review log 2845
Show 1020 earlier messages
-
Benni Mack uploaded patch set 1 09/24/25, 07:44
-
core-ci voted on patch set 1 V -1 09/24/25, 07:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85433
-
Benni Mack uploaded patch set 2
V -109/24/25, 08:17 -
core-ci voted on patch set 2 V -1 09/24/25, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85435
-
Benni Mack uploaded patch set 3
V -109/25/25, 20:26 -
core-ci voted on patch set 3 V -1 09/25/25, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85551
-
Benni Mack commented on patch set 4
V -109/25/25, 20:58Published edit on patch set 3. -
core-ci voted on patch set 4 V -1 09/25/25, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85552
-
Benni Mack uploaded patch set 5
V -109/26/25, 07:28 -
core-ci voted on patch set 5 V -1 09/26/25, 07:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85576
-
Benni Mack uploaded patch set 6
V -110/09/25, 15:28 -
core-ci voted on patch set 6 V -1 10/09/25, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86315
-
Benni Mack uploaded patch set 7
V -110/09/25, 19:22 -
core-ci voted on patch set 7 V -1 10/09/25, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86338
-
Benni Mack uploaded patch set 8
V -110/09/25, 19:40 -
core-ci voted on patch set 8 V -1 10/09/25, 19:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86339
-
Benni Mack uploaded patch set 9
V -110/09/25, 20:04 -
core-ci voted on patch set 9 V +1 10/09/25, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86340
-
Benni Mack uploaded patch set 10
V +110/13/25, 12:55 -
core-ci voted on patch set 10 V +1 10/13/25, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86542
-
Benni Mack uploaded patch set 11
V +110/13/25, 15:26 -
core-ci voted on patch set 11 V -1 10/13/25, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86560
-
Benni Mack uploaded patch set 12
V -110/13/25, 15:48 -
core-ci voted on patch set 12 V +1 10/13/25, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86564
-
Georg Ringer commented on patch set 12 10/13/25, 18:52
PageRepository.php:2068should we do a array_unique? -
Benni Mack commented on patch set 12 10/14/25, 06:38
PageRepository.php:2068Replynot worth it IMHO. in the end, RecordAccessVoter / UserAspect does an in_array() check - that's it. -
Christian Kuhn commented on patch set 12 10/15/25, 05:35
PageRepository.php:2068Replyyeah. hope its fine to keep as is.AbstractActionTestCase.php:456unused. -
Christian Kuhn commented on patch set 12 10/15/25, 05:38
PageRepository starts to *really* bite us. it becomes more and more apparent this needs a major overhaul that is based on all related records (pages, page translations and overlays) being fetched exactly once and then having checks on them. -
Christian Kuhn uploaded patch set 13
V +110/15/25, 05:40 -
Christian Kuhn commented on patch set 12 10/15/25, 05:41
Reply
this change does not help us structurally in any way, but i guess we'll have to pick it since it gives us a bugfix for a nasty details various people tried to fix already.AbstractActionTestCase.php:456ReplyDone -
Christian Kuhn voted on patch set 13 CR +1 V +1 10/15/25, 05:41
-
core-ci voted on patch set 13 V -1 10/15/25, 05:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86675
-
core-ci commented on patch set 13 10/15/25, 05:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86675
-
Christian Kuhn rebased onto patch set 14
CR +1V +110/15/25, 06:21 -
core-ci voted on patch set 14 V -1 10/15/25, 06:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86676
-
Christian Kuhn rebased onto patch set 15
V -110/15/25, 08:33 -
Christian Kuhn voted on patch set 15 CR +1 V +1 10/15/25, 08:34
-
Oli Bartsch updated the commit message in patch set 16
CR +1V +110/15/25, 08:41 -
Oli Bartsch voted on patch set 16 CR +1 V +1 10/15/25, 08:41
-
core-ci voted on patch set 15 V +1 10/15/25, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86696
-
core-ci voted on patch set 16 V +1 10/15/25, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86699
-
Christian Kuhn voted on patch set 16 CR +1 V +1 10/15/25, 10:07
-
Benni Mack voted on patch set 16 CR +2 V +2 10/15/25, 10:09
-
Benni Mack merged patch set 17 10/15/25, 10:09
-
Garvin Hicking wrote 01/20/26, 12:55
Created a revert of this change as I3cb5a6baf7c8d420c79c2cd242b2a33b5276c357