90783[BUGFIX] Improve performance of workspace records in PageRepository
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 1
Review log 56
-
Stefan Froemken uploaded patch set 1 09/24/25, 09:28
-
Benni Mack commented on patch set 1 09/24/25, 09:31
funnily enough, I pulled a change out of my stash. We actually reworked the method (which is finally internal since v13) to get a full $row in instead of the ID, so we do not have to make all the DB queries. In advance, I added this so the DB restrictions check is done separately. https://review.typo3.org/c/Packages/TYPO3.CMS/+/90782 -
Stefan Froemken commented on patch set 1 09/24/25, 09:38
Reply
Ahh. You found another call to getWorkspaceVersionOfRecord. I stumbeled over that coming from PageRepository::versionOL(). I counted the queries to ~800 and wondered about ~1.600 same queries in mysqlreport. Yes, reduzing the calls in general will help a lot. -
core-ci voted on patch set 1 V -1 09/24/25, 09:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85440
-
Benni Mack commented on patch set 1 01/29/26, 17:17
Hey Stefan, should we use this one now? https://review.typo3.org/c/Packages/TYPO3.CMS/+/90784 -
Stefan Froemken abandoned the change 02/14/26, 20:10
Better patch from Benni was used