Review main Merged

90784[TASK] Avoid duplicate DB queries in getWorkspaceVersionOfRecord

Benni Mack CR +2 V +2 Normal +21 −53 updated 02/13/26, 19:36

Commit message

PageRepository->getWorkspaceVersionOfRecord is suboptimal,
it receives a record "uid" and loads the full record,
does some magic with enableFields, and without etc.

First: We should hand over the full record, because we
only use it in 2 places.

Second: We can use RecordAccessVoter to deal with this
kind of stuff.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1830

Show 35 earlier messages
  1. Benni Mack uploaded patch set 1 09/24/25, 09:44

  2. core-ci voted on patch set 1 V -1 09/24/25, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85441

  3. Garvin Hicking updated the commit message in patch set 2 V -1 09/24/25, 09:59

  4. core-ci voted on patch set 2 V -1 09/24/25, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85442

  5. Benni Mack uploaded patch set 3 V -1 10/15/25, 13:05

  1. core-ci voted on patch set 3 V -1 10/15/25, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86727

  2. Benni Mack uploaded patch set 4 V -1 01/28/26, 16:33

  3. core-ci voted on patch set 4 V -1 01/28/26, 16:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94518

  4. Benni Mack uploaded patch set 5 V -1 01/28/26, 18:09

  5. core-ci voted on patch set 5 V -1 01/28/26, 18:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94525

  6. Benni Mack rebased onto patch set 6 V -1 01/29/26, 14:01

  7. core-ci voted on patch set 6 V -1 01/29/26, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94580

  8. Benni Mack uploaded patch set 7 V -1 01/29/26, 16:32

  9. core-ci voted on patch set 7 V -1 01/29/26, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94590

  10. Benni Mack uploaded patch set 8 V -1 01/29/26, 16:59

  11. core-ci voted on patch set 8 V +1 01/29/26, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94592

  12. Benni Mack commented on patch set 9 V +1 02/08/26, 12:53

    Published edit on patch set 8.
  13. Benni Mack updated the commit message in patch set 10 02/08/26, 12:55

  14. Benni Mack marked it ready for review 02/08/26, 12:55

  15. core-ci voted on patch set 10 V +1 02/08/26, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95409

  16. core-ci voted on patch set 9 V +1 02/08/26, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95408

  17. Garvin Hicking updated the commit message in patch set 11 V +1 02/08/26, 19:21

  18. core-ci voted on patch set 11 V +1 02/08/26, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95415

  19. Stefan Bürk uploaded patch set 12 V +1 02/13/26, 15:39

  20. core-ci voted on patch set 12 V +1 02/13/26, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95839

  21. Stefan Bürk voted on patch set 12 CR +1 V +1 02/13/26, 16:16

  22. Oliver Klee voted on patch set 12 V +1 02/13/26, 17:44

  23. Anja Leichsenring voted on patch set 12 CR +1 V +1 02/13/26, 19:20

  24. Benni Mack voted on patch set 12 CR +2 V +2 02/13/26, 19:36

  25. Benni Mack merged patch set 13 02/13/26, 19:36