Review main Merged Breaking

90787[!!!][FEATURE] Add PSR-14 Event after form is built

Josua Vogel CR +2 V +2 Hard +292 −177 updated 10/23/25, 12:51

Commit message

A new PSR-14 event TYPO3\CMS\Form\Event\BeforeRenderableIsAddedToFormEvent
has been introduced which serves, in addition to the event
TYPO3\CMS\Form\Event\BeforeRenderableIsAddedToFormEvent,
as an improved replacement for the now removed hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/form']['afterBuildingFinished'].

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 3048

Show 1223 earlier messages
  1. Josua Vogel uploaded patch set 1 09/24/25, 14:22

  2. core-ci voted on patch set 1 V -1 09/24/25, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85451

  3. Josua Vogel uploaded patch set 2 V -1 09/25/25, 14:32

  4. core-ci voted on patch set 2 V -1 09/25/25, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85528

  5. Josua Vogel updated the commit message in patch set 3 V -1 09/25/25, 14:40

  6. core-ci voted on patch set 3 V -1 09/25/25, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85529

  7. Josua Vogel uploaded patch set 4 V -1 09/26/25, 11:54

  8. core-ci voted on patch set 4 V -1 09/26/25, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85599

  9. Josua Vogel uploaded patch set 5 V -1 09/26/25, 12:55

  10. Josua Vogel uploaded patch set 6 09/26/25, 12:57

  11. core-ci voted on patch set 5 V -1 09/26/25, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85605

  12. core-ci voted on patch set 6 V -1 09/26/25, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85606

  13. Josua Vogel uploaded patch set 7 V -1 09/26/25, 13:22

  14. core-ci voted on patch set 7 V +1 09/26/25, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85611

  15. Simon Schaufelberger uploaded patch set 8 V +1 10/01/25, 19:41

  16. core-ci voted on patch set 8 V +1 10/01/25, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85836

  17. Josua Vogel uploaded patch set 9 V +1 10/07/25, 12:55

  18. core-ci voted on patch set 9 V +1 10/07/25, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86155

  19. Simon Schaufelberger commented on patch set 9 10/10/25, 09:25

    AbstractFormFactory.php:58

    this must be protected to be used in subclasses.
  20. Josua Vogel uploaded patch set 10 V +1 10/11/25, 14:11

  21. core-ci voted on patch set 10 V -1 10/11/25, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86464

  22. Josua Vogel uploaded patch set 11 V -1 10/11/25, 14:25

  23. core-ci voted on patch set 11 V +1 10/11/25, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86466

  1. Josua Vogel commented on patch set 11 10/11/25, 14:51

    AbstractFormFactory.php:58 Reply

    Done, switched to method injection, because it´s recommended for abstract classes
  2. Sven Liebert voted on patch set 11 CR +1 V +1 10/15/25, 16:00

  3. Georg Ringer uploaded patch set 12 CR +1 V +1 10/15/25, 19:41

  4. core-ci voted on patch set 12 V +1 10/15/25, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86764

  5. Sven Liebert voted on patch set 12 CR +1 V +1 10/15/25, 19:59

  6. Josua Vogel uploaded patch set 13 CR +1 V +1 10/21/25, 08:14

  7. core-ci voted on patch set 13 V -1 10/21/25, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87150

  8. Josua Vogel uploaded patch set 14 V -1 10/22/25, 06:26

  9. core-ci voted on patch set 14 V +1 10/22/25, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87217

  10. Sven Liebert voted on patch set 14 CR +1 V +1 10/22/25, 06:46

  11. Josua Vogel uploaded patch set 15 CR +1 V +1 10/22/25, 13:19

  12. core-ci voted on patch set 15 V +1 10/22/25, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87265

  13. Sven Liebert voted on patch set 15 CR +1 V +1 10/22/25, 18:25

  14. Josua Vogel uploaded patch set 16 CR +1 V +1 10/23/25, 05:48

  15. core-ci voted on patch set 16 V -1 10/23/25, 05:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87372

  16. Josua Vogel uploaded patch set 17 V -1 10/23/25, 05:58

  17. core-ci voted on patch set 17 V +1 10/23/25, 06:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87373

  18. Sven Liebert voted on patch set 17 CR +1 V +1 10/23/25, 07:21

  19. Oli Bartsch uploaded patch set 18 CR +1 V +1 10/23/25, 10:36

  20. Oli Bartsch commented on patch set 17 CR +1 V +1 10/23/25, 10:37

    Feature-98239-IntroducePSR14AfterFormIsBuiltEvent.rst:14

    AfterFormIsBuiltEvent
  21. core-ci voted on patch set 18 V +1 10/23/25, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87403

  22. Oli Bartsch voted on patch set 18 CR +1 V +1 10/23/25, 10:44

  23. Sven Liebert voted on patch set 18 CR +1 V +1 10/23/25, 11:13

  24. Oli Bartsch voted on patch set 18 CR +2 V +2 10/23/25, 12:51

  25. Oli Bartsch merged patch set 19 10/23/25, 12:51