Review main Merged

90788[TASK] Avoid costly database schema queries and class state

Stefan Bürk CR +2 V +2 Normal +20 −50 updated 10/09/25, 10:05

Commit message

Some places in our code base need to deal with database schema
information, which are quite costly doing them over and over again.

This change streamlines occurrences to use the internal cached
schema information (`Connection->getSchemaInformation()`) to
replace the occurrences and centralizing them to one place. With
that, instance state can be removed in two cases and in one case
the uncached usage replaced by the cached schema information.

Note that `SchemaInformation` uses only a code cache right now
and will get a second level (`runtime`) cache in a dedicated
change eliminating the need to read it from PHP files over and
over again.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 5

Files 4

Review log 2139

Show 714 earlier messages
  1. Stefan Bürk uploaded patch set 1 09/24/25, 15:21

  2. core-ci voted on patch set 1 V -1 09/24/25, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85456

  3. Stefan Bürk uploaded patch set 2 V -1 09/24/25, 16:07

  4. core-ci voted on patch set 2 V -1 09/24/25, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85462

  5. Stefan Bürk uploaded patch set 3 V -1 09/24/25, 16:15

  6. core-ci voted on patch set 3 V +1 09/24/25, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85463

  7. core-ci voted on patch set 3 V -1 09/24/25, 16:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85464

  8. Stefan Bürk commented on patch set 3 09/24/25, 17:01

    Note, nightly https://git.typo3.org/typo3/CI/cms/-/pipelines/85464 literally green, failure is current occuring generic phpstan issue.
  9. Stefan Bürk rebased onto patch set 4 V -1 09/26/25, 11:20

  10. core-ci voted on patch set 4 V -1 09/26/25, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85595

  11. Stefan Bürk rebased onto patch set 5 V -1 09/26/25, 11:45

  12. core-ci voted on patch set 5 V -1 09/26/25, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85598

  13. Stefan Bürk uploaded patch set 6 V -1 09/26/25, 12:40

  14. core-ci voted on patch set 6 V +1 09/26/25, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85603

  1. core-ci voted on patch set 6 V -1 09/26/25, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85604

  2. Stefan Bürk rebased onto patch set 7 V -1 09/26/25, 15:36

  3. core-ci voted on patch set 6 V -1 09/26/25, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85604

  4. core-ci voted on patch set 7 V +1 09/26/25, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85615

  5. Stefan Bürk rebased onto patch set 8 V +1 10/01/25, 08:37

  6. core-ci voted on patch set 8 V +1 10/01/25, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85790

  7. Stefan Bürk uploaded patch set 9 V +1 10/06/25, 14:22

  8. Stefan Bürk marked it ready for review 10/06/25, 14:23

  9. core-ci voted on patch set 9 V +1 10/06/25, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86073

  10. Stefan Bürk rebased onto patch set 10 V +1 10/07/25, 08:19

  11. core-ci voted on patch set 10 V +1 10/07/25, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86136

  12. Stefan Bürk rebased onto patch set 11 V +1 10/07/25, 13:21

  13. core-ci voted on patch set 11 V +1 10/07/25, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86163

  14. Stefan Bürk rebased onto patch set 12 V +1 10/07/25, 17:39

  15. core-ci voted on patch set 12 V +1 10/07/25, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86174

  16. Stefan Bürk rebased onto patch set 13 V +1 10/07/25, 17:52

  17. core-ci voted on patch set 13 V +1 10/07/25, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86177

  18. Stefan Bürk uploaded patch set 14 V +1 10/08/25, 10:08

  19. core-ci voted on patch set 14 V +1 10/08/25, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86217

  20. Stefan Bürk rebased onto patch set 15 V +1 10/08/25, 18:40

  21. core-ci voted on patch set 15 V +1 10/08/25, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86252

  22. Christian Kuhn voted on patch set 15 CR +1 V +1 10/09/25, 00:10

  23. Benjamin Franzke voted on patch set 15 CR +1 V +1 10/09/25, 08:36

  24. Stefan Bürk voted on patch set 15 CR +2 V +2 10/09/25, 09:51

  25. Stefan Bürk merged patch set 16 10/09/25, 10:05