90790[BUGFIX] Use full row to check permissions deleting a record
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Garvin Hicking +1
- Elias Häußler +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Elias Häußler +1
- core-ci +1 CI
Issues 1
Files 1
Review log 910
-
Georg Ringer uploaded patch set 1 09/24/25, 16:38
-
Georg Ringer commented on patch set 1 09/24/25, 16:38
This change is ready for review. -
core-ci voted on patch set 1 V +1 09/24/25, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85465
-
Elias Häußler voted on patch set 1 CR +1 V +1 10/14/25, 11:50
-
Oliver Klee voted on patch set 1 CR +1 10/14/25, 12:03
-
Benni Mack voted on patch set 1 CR +1 V +1 10/14/25, 12:19
-
Garvin Hicking commented on patch set 1 10/14/25, 19:25
DataHandler.php:5527Do we really need to be this open? I know installations where tables can have very large JSON blobs. these would all get loaded here even though of no use. Couldn't we just iterate needed columns? TCA Schema maybe? -
Garvin Hicking commented on patch set 1 CR +1 V +1 11/10/25, 14:18
DataHandler.php:5527ReplyLet's postone this. Even iterating fields will be hard to decide what is part of a permission check, and what not. In the end we would probably need a TCA config or so that says "thisIsABigColumnPleaseDoNotFetchMeInAWildCardSelectPrettyPlease=true". (that creates a whole lot of other woes). As such, I'm resolving my note and let's see what the future holds. For now this fixes a bug. 😄 (sorry for the hold-up, this was more meant as a question to foster discussion and not as a showstopper - always feel free to get in touch if this is the feeling) -
Benni Mack voted on patch set 1 CR +2 V +2 11/10/25, 15:13
-
Benni Mack merged patch set 2 11/10/25, 15:13