Review main Merged

90790[BUGFIX] Use full row to check permissions deleting a record

Georg Ringer CR +2 V +2 Easy +1 −1 updated 11/10/25, 15:13

Commit message

The DataHandler loads all rows which are to be leaded and requires
the full row. Otherwise later permission checks in
`BackendUserAuthentication::recordEditAccessInternals` leads to an error message
`ERROR: The "languageField" field named "sys_languge_uid" was not found in testing record`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Elias Häußler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Georg Ringer uploaded patch set 1 09/24/25, 16:38

  2. Georg Ringer commented on patch set 1 09/24/25, 16:38

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/24/25, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85465

  4. Elias Häußler voted on patch set 1 CR +1 V +1 10/14/25, 11:50

  5. Oliver Klee voted on patch set 1 CR +1 10/14/25, 12:03

  6. Benni Mack voted on patch set 1 CR +1 V +1 10/14/25, 12:19

  7. Garvin Hicking commented on patch set 1 10/14/25, 19:25

    DataHandler.php:5527

    Do we really need to be this open? I know installations where tables can have very large JSON blobs. these would all get loaded here even though of no use. Couldn't we just iterate needed columns? TCA Schema maybe?
  8. Garvin Hicking commented on patch set 1 CR +1 V +1 11/10/25, 14:18

    DataHandler.php:5527 Reply

    Let's postone this. Even iterating fields will be hard to decide what is part of a permission check, and what not. In the end we would probably need a TCA config or so that says "thisIsABigColumnPleaseDoNotFetchMeInAWildCardSelectPrettyPlease=true". (that creates a whole lot of other woes). As such, I'm resolving my note and let's see what the future holds. For now this fixes a bug. 😄 (sorry for the hold-up, this was more meant as a question to foster discussion and not as a showstopper - always feel free to get in touch if this is the feeling)
  9. Benni Mack voted on patch set 1 CR +2 V +2 11/10/25, 15:13

  10. Benni Mack merged patch set 2 11/10/25, 15:13