Review main Merged

90794[TASK] Remove main application services from failsafe container

Benjamin Franzke CR +2 V +2 Hard +80 −267 updated 10/29/25, 05:32

Commit message

Since #107536 we are able to serve the typo3 installer and maintenance
tool from the main index.php entrypoint, which means we can remove any
failsafe compatibility requirements from the main application classes,
allowing to use the full set of symfony DI features, without needing
applications to be defined in the failsafe container only to be
able to redirect to the install tool.

This mainly allows to inject services and use symfony DI, reducing
the amount of services that need to be manually wired in
service providers.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 20

Review log 1016

  1. Benjamin Franzke uploaded patch set 1 09/25/25, 09:02

  2. core-ci voted on patch set 1 V -1 09/25/25, 09:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85493

  3. Benjamin Franzke uploaded patch set 2 V -1 09/25/25, 10:53

  4. core-ci voted on patch set 2 V +1 09/25/25, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85501

  5. Benjamin Franzke uploaded patch set 3 09/25/25, 11:37

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  6. core-ci voted on patch set 3 V +1 09/25/25, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85506

  7. Benjamin Franzke uploaded patch set 4 V +1 10/01/25, 11:06

  8. core-ci voted on patch set 4 V -1 10/01/25, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85803

  9. Benjamin Franzke uploaded patch set 5 V -1 10/01/25, 11:52

  10. core-ci voted on patch set 5 V +1 10/01/25, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85811

  11. Benjamin Franzke uploaded patch set 6 V +1 10/01/25, 13:44

  12. core-ci voted on patch set 6 V +1 10/01/25, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85822

  13. Benni Mack voted on patch set 6 CR +1 V +1 10/02/25, 21:07

  14. Simon Schaufelberger voted on patch set 6 CR +1 V +1 10/21/25, 18:58

  15. Benjamin Franzke voted on patch set 6 CR +2 V +2 10/29/25, 05:32

  16. Benjamin Franzke merged patch set 7 10/29/25, 05:32