90797[BUGFIX] Ignore mime type parameters for video/audio tag renderer
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Georg Ringer +1
-
Verified V +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2128
Show 3 earlier messages
-
Philipp Radler voted on patch set 3 CR +1 09/25/25, 12:01
-
Philipp Radler voted on patch set 3 V +1 09/25/25, 12:01
-
Markus Klein uploaded patch set 4
CR +1V +109/25/25, 12:13 -
Markus Klein updated the commit message in patch set 5 09/25/25, 12:13
-
core-ci voted on patch set 3 V -1 09/25/25, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85513
-
core-ci voted on patch set 1 V -1 09/25/25, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85509
-
Markus Klein uploaded patch set 6 09/25/25, 12:20
-
core-ci voted on patch set 2 V -1 09/25/25, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85512
-
Johannes Kasberger voted on patch set 6 CR +1 V +1 09/25/25, 12:20
-
Mathias Brodala commented on patch set 5 09/25/25, 12:26
-
core-ci voted on patch set 4 V -1 09/25/25, 12:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85514
-
core-ci voted on patch set 5 V -1 09/25/25, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85515
-
Markus Klein commented on patch set 6 09/25/25, 12:29
VideoTagRenderer.php:60ReplyI'd opt to fix this the easy way and do a cleanup in v14 only then. -
core-ci voted on patch set 6 V +1 09/25/25, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85516
-
Garvin Hicking commented on patch set 6 09/25/25, 16:59
How does this mime type get into the DB? There are probably many more cases where this might fail - shouldn resource integrity validators fail here, too? -
Markus Klein commented on patch set 6 09/25/25, 17:13
Reply
Our case is an S3 compatible storage. I can't tell at the moment, how exactly this happens, but we studied the specs and found out that those parameters are indeed legit (even if optional). So that's why I decided to fix the Core to behave according to standards. We didn't find any other issues with the mime type yet, but no doubt, there could be more hidden gems. -
Garvin Hicking commented on patch set 6 09/25/25, 17:35
Reply
Would it maybe be better to scrub the mimetype of parameters before persisting to the DB? I'm afraid this patch might be very symptomatic. Ideally we'd have a getMimeTypeWithoutParams() or so, and replace that everywhere, but that is indeed v14 scope (for a month... then it's v15 scope 😂) -
Markus Klein marked it work in progress 11/22/25, 18:26
-
Georg Ringer uploaded patch set 7
CR +1V +109/30/26, 19:03Rebased, added lowercase/trim handling and tests as suggested in review. Normalizing mime types on persist should be a separate main-only change. -
core-ci voted on patch set 7 V +1 09/30/26, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109687
-
Markus Klein commented on patch set 7 09/30/26, 19:33
This change is ready for review.VideoTagRenderer.php:60ReplyDone -
Markus Klein commented on patch set 7 09/30/26, 19:34
Reply
Let's do cleanup stuff in v15 -
Georg Ringer voted on patch set 7 CR +1 V +1 10/01/26, 21:12
-
Garvin Hicking voted on patch set 7 CR +2 V +2 10/02/26, 05:12
-
Garvin Hicking merged patch set 8 10/02/26, 08:57
VideoTagRenderer.php:60