Review main Merged

90800[TASK] Avoid calling deprecated `ReflectionMethod::setAccessible()`

Stefan Bürk CR +2 V +2 Easy +0 −7 updated 09/26/25, 16:08

Commit message

Calling `ReflectionMethod::setAccessible()` triggers

    Method ReflectionMethod::setAccessible() is deprecated since
    8.5, as it has no effect

deprecation notice and can simply removed being no-operational
since PHP 8.1 already and occurs only in tests.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Stefan Bürk uploaded patch set 1 09/25/25, 17:03

  2. Oliver Klee updated the commit message in patch set 2 09/25/25, 17:08

  3. Oliver Klee voted on patch set 2 CR +1 V +1 09/25/25, 17:08

  4. core-ci voted on patch set 1 V +1 09/25/25, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85538

  5. Markus Klein voted on patch set 2 CR +1 V +1 09/25/25, 17:14

  6. core-ci voted on patch set 2 V +1 09/25/25, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85539

  7. Benni Mack voted on patch set 2 CR +1 V +1 09/26/25, 12:34

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 09/26/25, 14:05

  9. Stefan Bürk merged patch set 3 09/26/25, 16:08