Review main Merged

90804[BUGFIX] Remove double encoding of LinkBrowser label output

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 09/26/25, 11:15

Commit message

The menu tabs of the LinkBrowser emitted labels by
using `htmlspecialchars()` in the assignment of
`AbstractLinkBrowserController->loadLinkHandlers()`.

This label gets extracted by `buildMenuArray()`. This method is
called in the `mainAction` of the link browser abstract, which
assigns that array to `{menuItems}` to be used in the Fluid template
`typo3/sysext/backend/Resources/Private/Layouts/LinkBrowser.html`.
There, the usual Fluid safeguards for escaping output
are in place.

By removing the extra `htmlspecialchars` characters like
a single quote (as reported in the issue) no longer get
mangled.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1317

  1. Garvin Hicking uploaded patch set 1 09/25/25, 19:04

  2. core-ci voted on patch set 1 V +1 09/25/25, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85546

  3. Garvin Hicking commented on patch set 1 09/25/25, 19:31

    damn.
  4. Garvin Hicking uploaded patch set 2 V +1 09/26/25, 07:00

  5. core-ci voted on patch set 2 V +1 09/26/25, 07:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85572

  6. Benjamin Franzke updated the commit message in patch set 3 V +1 09/26/25, 07:16

  7. Benjamin Franzke voted on patch set 3 CR +1 V +1 09/26/25, 07:16

  8. core-ci voted on patch set 3 V +1 09/26/25, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85573

  9. Anja Leichsenring voted on patch set 3 CR +1 V +1 09/26/25, 07:44

  10. Guido Schmechel commented on patch set 3 09/26/25, 08:13

    (Sorry) CommitMessage: AbstractLinkBrowsreCocntroller->loadLinkHandlers()
  11. Garvin Hicking updated the commit message in patch set 4 CR +1 V +1 09/26/25, 08:31

  12. Simon Schaufelberger voted on patch set 4 CR +1 V +1 09/26/25, 08:37

  13. core-ci voted on patch set 4 V +1 09/26/25, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85582

  14. Benjamin Franzke voted on patch set 4 CR +1 V +1 09/26/25, 08:47

  15. Garvin Hicking voted on patch set 4 CR +2 V +2 09/26/25, 08:49

  16. Oliver Klee voted on patch set 4 CR +1 09/26/25, 09:21

  17. Garvin Hicking merged patch set 5 09/26/25, 11:15