Review main Merged

90805[BUGFIX] Do not strip public path from given realpath of a file

Helmut Hummel CR +2 V +2 Easy +7 −7 updated 10/01/25, 09:14

Commit message

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1115

  1. Helmut Hummel uploaded patch set 1 09/25/25, 21:33

  2. core-ci voted on patch set 1 V -1 09/25/25, 21:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85553

  3. Helmut Hummel uploaded patch set 2 V -1 09/26/25, 06:50

  4. core-ci voted on patch set 2 V +1 09/26/25, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85571

  5. Garvin Hicking commented on patch set 2 CR +1 V +1 09/26/25, 07:19

    This seems to do the job for the monorepo and composer installs I have tried with. Unsure about the v12 scope, I'd say those people live long enough with the bug/issue that we should not risk any possible side effects it could have - I'd opt for main+v13 only.
  6. Helmut Hummel commented on patch set 2 09/26/25, 07:21

    Reply

    The questionmarks I put there was like: "was this code really introduced in v12 already or rather v13"
  7. Benjamin Franzke updated the commit message in patch set 3 CR +1 V +1 09/26/25, 07:27

  8. Garvin Hicking commented on patch set 3 09/26/25, 07:29

    Reply

    Ah right, ImageInfo wasn't in v12. https://review.typo3.org/c/Packages/TYPO3.CMS/+/82332 seems to have introduced the stripping, earlier code resolved the paths differently. So let's remove 12.4.
  9. Garvin Hicking updated the commit message in patch set 4 09/26/25, 07:29

  10. Garvin Hicking voted on patch set 4 CR +1 V +1 09/26/25, 07:29

  11. core-ci voted on patch set 3 V +1 09/26/25, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85575

  12. core-ci voted on patch set 4 V +1 09/26/25, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85577

  13. Benni Mack voted on patch set 4 CR +1 V +1 09/29/25, 09:33

  14. Helmut Hummel voted on patch set 4 CR +2 V +2 10/01/25, 09:14

  15. Helmut Hummel merged patch set 5 10/01/25, 09:14