9081[BUGFIX] Toolbar Separator IE8 and FF3.6
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Philipp Gampe +1
-
Verified V +2
- Steffen Ritter +2
- Philipp Gampe +1
Files 6
- typo3/sysext/opendocs/opendocs.css+9 −1
- typo3/sysext/t3skin/stylesheets/structure/toolbar.css1+15 −9
- typo3/sysext/t3skin/stylesheets/structure/toolbar_username.css+19 −4
- typo3/sysext/t3skin/stylesheets/visual/toolbar.css+4 −0
- typo3/sysext/t3skin/stylesheets/visual/toolbar_livesearch.css+5 −1
- typo3/sysext/t3skin/stylesheets/visual/toolbar_username.css+0 −1
Review log 20
-
Philipp Gampe commented on patch set 1 03/07/12, 08:02
Verified; Looks good to me, but someone else must approve Looks much better. Chromium: The username text is not at the center, but closer to the top. It should be aligned to the logout text if this is possible. The search does not close other dropdowns if opened. Other browsers will follow soon.toolbar.css:50At least for Firefox and Chromium on Fedora, it should be 2px. -
Philipp Gampe commented on patch set 1 03/07/12, 08:02
Windows 7: Firefox: OK Chrome: OK Opera: OK Safari: OK, but the open documents box is miss-aligned IE 9: OK, but same as Safari IE 8: OK, but same as Safari Windows Vista: IE 7: OK -
Philipp Gampe commented on patch set 2 03/07/12, 08:02
Last word should have been Linux ;) Also tested with my suggested 2px padding-top for .toolbar-item -
Philipp Gampe commented on patch set 2 03/07/12, 08:02
@Felix, please always tell us why you have uploaded a new patchset. -
Philipp Gampe commented on patch set 2 03/07/12, 08:02
(1 inline comment) Now tested again on all browser: IE 7-9 on Windows + Firefox + Safari + Opera + Chrome Opera, Firefox and Chromium on Windows -
Felix Kopp uploaded patch set 2 03/07/12, 08:02
-
Felix Kopp commented on patch set 2 03/07/12, 08:02
Please review. -
Steffen Ritter commented on patch set 3 03/07/12, 08:02
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 3 03/07/12, 08:02
Verified; Looks good to me, but someone else must approve Thanks for the screenshots. I tested again with all mentioned browsers and only the IE7 shows those slight alignment issues (like in you screenshot). IMHO this is OK, because IE7 is rarely used. -
Felix Kopp commented on patch set 3 03/07/12, 08:02
@Philipp: Thanks for the hint - of course I will write about the changes. Never thought about that. Patchset now includes: * Makes separator lines equally long (username was shorter). * Includes Philipps hint about top padding (2px instead of 1px) in active fly-out * For IE8/Win7 the open documents counter number is vertically centered -
Felix Kopp commented on patch set 3 03/07/12, 08:02
Dear Patch, please make it into 4.7. Yours, Felix -
Felix Kopp commented on patch set 3 03/07/12, 08:02
Please find screenshots for this patchset 3 on Forge: http://forge.typo3.org/issues/34020 -
Felix Kopp commented on patch set 3 03/07/12, 08:02
Also we can only adress these issues with conditional comments (do not like these) or different css for the browsers. Different CSS should be introduced for all of TYPO3 (imo). -
Felix Kopp uploaded patch set 3 03/07/12, 08:02
-
Mr. Jenkins commented on patch set 1 03/07/12, 08:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3303/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/07/12, 08:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3356/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/07/12, 08:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3403/ : SUCCESS -
Wouter Wolters commented on patch set 2 03/07/12, 08:02
Verified; Looks good to me, but someone else must approve Tested in: Firefox 10, IE9, IE8, IE7, Chrome on Windows 7 -
Steffen Ritter commented on patch set 3 V 0 03/07/12, 08:02
by team member; Looks good to me, approved -
Steffen Ritter merged patch set 3 03/07/12, 08:02