90811[BUGFIX] Align SplitButton usage to allow LinkButton
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Anja Leichsenring +1
- Stefan Froemken +1
-
Verified V +2 Done
- Garvin Hicking +2
- Anja Leichsenring +1
- Stefan Froemken +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1115
-
Garvin Hicking uploaded patch set 1 09/26/25, 11:03
-
core-ci voted on patch set 1 V -1 09/26/25, 11:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85591
-
Garvin Hicking uploaded patch set 2
V -109/26/25, 11:16 -
core-ci voted on patch set 2 V +1 09/26/25, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85593
-
Garvin Hicking uploaded patch set 3
V +110/10/25, 15:24 -
core-ci voted on patch set 3 V +1 10/10/25, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86414
-
Garvin Hicking wrote 10/13/25, 07:11
Topic set to buttonbar -
Anja Leichsenring updated the commit message in patch set 4
V +110/17/25, 06:34 -
core-ci voted on patch set 4 V +1 10/17/25, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86866
-
Anja Leichsenring voted on patch set 4 CR +1 V +1 10/17/25, 07:15
-
Stefan Froemken commented on patch set 4 10/17/25, 09:30
Hi Garvin. Thank you for taking care of that issue. For me I'm fine with the patch and I can adopt that for my german documentation. But makeInputButtons within the dropdown are still rendered as link instead of real buttons like the primary button. You told me about a follow-up. Do you need +1 now, or is that something which has to be solved within this patch here?SplitButton.php:42These two inputButtons are still rendered as link buttons instead of <button>: <a href="#" data-name="save_and_show" data-value="1" data-form="" class=" dropdown-item">...</a> -
Garvin Hicking commented on patch set 4 10/17/25, 12:34
SplitButton.php:42ReplyI'm afraid I think this is a bit "legacy". You can see from the other input buttons on the main row of the EditDocumentController: ``` <a role="button" href="https://typo3-core-bugreproduce-base.ddev.site/en/goerk" class="btn btn-sm btn-default t3js-editform-view" title="View"> ``` Since the core no longer has SplitButton usage, I'm a bit too afraid changing this would be a breaking change to existing installations (due to how CSS/JS might be handled, and even how the core might react on a "button" element at this place). So it would need to be a follow-up only addressing "main" for this. Visually, it looks consistent to me that the `<a href>` (even though being a "InputButton") looks like a button and acts like one. -
Stefan Froemken commented on patch set 4 CR +1 V +1 10/17/25, 17:07
SplitButton.php:42ReplyDone -
Garvin Hicking voted on patch set 4 CR +2 V +2 10/23/25, 06:27
-
Garvin Hicking merged patch set 5 10/23/25, 06:38