Review main Merged

90813[BUGFIX] Enable EnvironmentStatusReport for cli

Oli Bartsch CR +2 V +2 Easy +0 −3 updated 10/06/25, 14:26

Commit message

Having the EnvironmentStatusReport disabled for CLI
it makes the report scheduler task useless.

Enable it and let the tests check.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1213

  1. Oli Bartsch uploaded patch set 1 09/26/25, 11:56

  2. Oli Bartsch abandoned the change 09/26/25, 11:57

  3. Oli Bartsch restored the change 09/26/25, 11:59

  4. core-ci voted on patch set 1 V +1 09/26/25, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85600

  5. Benni Mack commented on patch set 1 09/26/25, 12:11

    EnvironmentStatusReport.php:44

    is this one relevant as well?
  6. Oli Bartsch commented on patch set 1 09/29/25, 10:05

    EnvironmentStatusReport.php:44 Reply

    This method is only called in backend context (Reports Module).
  7. Benni Mack voted on patch set 1 CR +1 09/30/25, 10:05

  8. Benni Mack voted on patch set 1 V +1 10/01/25, 16:00

  9. Garvin Hicking voted on patch set 1 CR +1 V +1 10/02/25, 10:25

  10. Oli Bartsch voted on patch set 1 CR +2 V +2 10/02/25, 11:13

  11. Oli Bartsch merged patch set 2 10/02/25, 11:13

  12. Benjamin Franzke commented on patch set 2 10/06/25, 07:12

    EnvironmentStatusReport.php:43 Unresolved

    `TYPO3\CMS\Install\SystemEnvironment\SetupCheck` uses `$_SERVER['HTTP_HOST']` to perform tests against the webserver. This server variable is not available in CLI context. That means we can not unconditionally run the environment status report in this scenario. I've created an issue to track that bug https://forge.typo3.org/issues/107607 An alternative approach could be to make it configurable which target server is to be tested and allow execution in CLI context only if this configuration has been provided.
  13. Benjamin Franzke wrote 10/06/25, 14:26

    Created a revert of this change as If2a6e62b1a396d9c6fdeacc6f756fa172525954a