Review 13.4 Merged

90820Revert "[DOCS] Correct permalinks in EXT:form"

Garvin Hicking CR +2 V +2 Easy +25 −25 updated 09/27/25, 12:31

Commit message

This reverts commit 1b102268ebd64a1c398bce8f29391bcf71fa99e3.

Reason for revert: The permalink docs.typo3.org access
was broken for some time, because links like

  https://docs.typo3.org/permalink/typo3/cms-scheduler:developer-guide

inadvertently got shared, while actually links needed to point to

  https://docs.typo3.org/permalink/typo3-cms-scheduler:developer-guide

via HTTP.

This was recently fixed in the docs.typo3.org permalink tool:

  https://github.com/TYPO3GmbH/site-intercept/pull/239

This commit was made under the assumption, the permalinks should be
converted to their original "canonical" format, too.

However, the RST syntax parsing actually uses the `typo3/cms-scheduler`
notation to be parsed. Using a `typo3-cms-scheduler` notation there is
NOT recognized by the render-guides parsers. Thus, the links using that
resolving are not parsed with their proper interlink repositories.

Due to this, the change should be reverted to not let the documentation
rendering (and nightlies) fail. A change to render-guides must first be
made to also allow both syntaxes, before this patch can be implemented
in TYPO3 documentation files (or it can be left as it is currently).

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 9

Review log 610

  1. Garvin Hicking commented on patch set 1 09/27/25, 10:26

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Documentation/Changelog/14.0/Feature-106363-ModifyPagesForIntegrityCheck.rst * typo3/sysext/form/Documentation/D/FormEditor/Index.rst * typo3/sysext/scheduler/Documentation/Administration/EditTask/Index.rst * typo3/sysext/scheduler/Documentation/DevelopersGuide/Events/Index.rst
  2. Garvin Hicking commented on patch set 2 09/27/25, 10:33

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 09/27/25, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85639

  4. Stefan Bürk updated the commit message in patch set 3 09/27/25, 10:36

  5. core-ci voted on patch set 2 V +1 09/27/25, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85641

  6. core-ci voted on patch set 3 V +1 09/27/25, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85642

  7. core-ci commented on patch set 3 09/27/25, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85644

  8. Garvin Hicking marked it ready for review 09/27/25, 11:51

  9. Garvin Hicking voted on patch set 3 CR +2 V +2 09/27/25, 12:31

  10. Garvin Hicking merged patch set 4 09/27/25, 12:31