Review main Merged

90832[BUGFIX] Use proxified interface for ext:form ConfigurationManager

Oliver Hader CR +2 V +2 Easy +1 −1 updated 09/29/25, 07:44

Commit message

`TYPO3\CMS\Form\Mvc\Configuration\ConfigurationManager` is a readonly
class and can not be proxified with PHP < 8.3 as of
symfony/dependency-injection v7.3.4 when declared as lazy service
dependency. Thus, the corresponding `ConfigurationManagerInterface`
is proxied instead.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Oliver Hader uploaded patch set 1 09/27/25, 20:27

  2. core-ci voted on patch set 1 V +1 09/27/25, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85649

  3. Oliver Klee voted on patch set 1 CR +1 09/28/25, 08:12

  4. Benjamin Franzke updated the commit message in patch set 2 CR +1 V +1 09/29/25, 06:56

  5. core-ci voted on patch set 2 V +1 09/29/25, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85680

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 09/29/25, 07:34

  7. Oliver Hader voted on patch set 2 CR +2 V +2 09/29/25, 07:44

  8. Oliver Hader merged patch set 3 09/29/25, 07:44