Review main Merged

90839[BUGFIX] Respect lock creation state in `backend:lock` command

Andreas Kienast CR +2 V +2 Easy +18 −12 updated 10/14/25, 09:27

Commit message

The method `LockService->lockBackend()` now passes through the return
value of `GeneralUtility::writeFile()`, allowing the `backend:lock`
command to return a proper exit code when the file creation failed.

The `BackendLocker` service class is now also marked as internal
like it was intended, to allow refactoring.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Markus Klein +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Markus Klein +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1520

  1. Andreas Kienast uploaded patch set 1 09/30/25, 05:39

  2. Andreas Kienast uploaded patch set 2 09/30/25, 05:44

  3. core-ci voted on patch set 1 V +1 09/30/25, 05:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85726

  4. core-ci voted on patch set 2 V +1 09/30/25, 05:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85727

  5. Oliver Klee updated the commit message in patch set 3 V +1 09/30/25, 06:48

  6. core-ci voted on patch set 3 V +1 09/30/25, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85729

  7. Oliver Klee rebased onto patch set 4 V +1 10/13/25, 11:33

  8. core-ci voted on patch set 4 V +1 10/13/25, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86538

  9. Markus Klein voted on patch set 4 CR +1 10/13/25, 11:56

  10. Georg Ringer voted on patch set 4 CR +1 V +1 10/13/25, 18:54

  11. Garvin Hicking commented on patch set 4 10/13/25, 19:44

    BackendLocker.php:31

    I think we should make this class internal while we're at it? I hope no one extended it for this to be breaking in 13.4?
  12. Josef Glatz commented on patch set 4 CR +1 V +1 10/13/25, 19:59

    Regarding the decision of whether the class should be declared as internal also in v13, I'm afraid I'll have to pass. From my perspective, the function and code are fine. Correct exit code received.
  13. Andreas Kienast commented on patch set 4 10/14/25, 05:38

    BackendLocker.php:31 Reply

    Fine for me, I don't have any opinion on this. Please feel free to push a new patch set.
  14. Garvin Hicking commented on patch set 5 CR +1 V +1 10/14/25, 06:26

    Published edit on patch set 4.
  15. Garvin Hicking commented on patch set 5 CR +1 V +1 10/14/25, 06:27

    BackendLocker.php:31 Reply

    Thanks, done - hope that's fine, but I believe this was the initial intention too, due to the "refactoring" class comment.
  16. core-ci voted on patch set 5 V +1 10/14/25, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86597

  17. Josef Glatz voted on patch set 5 CR +1 V +1 10/14/25, 06:44

  18. Markus Klein voted on patch set 5 CR +1 V +1 10/14/25, 08:22

  19. Andreas Kienast voted on patch set 5 CR +2 V +2 10/14/25, 09:15

  20. Andreas Kienast merged patch set 6 10/14/25, 09:27