90839[BUGFIX] Respect lock creation state in `backend:lock` command
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Josef Glatz +1
- Markus Klein +1
- Garvin Hicking +1
-
Verified V +2 Done
- Andreas Kienast +2
- Josef Glatz +1
- Markus Klein +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1520
-
Andreas Kienast uploaded patch set 1 09/30/25, 05:39
-
Andreas Kienast uploaded patch set 2 09/30/25, 05:44
-
core-ci voted on patch set 1 V +1 09/30/25, 05:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85726
-
core-ci voted on patch set 2 V +1 09/30/25, 05:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85727
-
Oliver Klee updated the commit message in patch set 3
V +109/30/25, 06:48 -
core-ci voted on patch set 3 V +1 09/30/25, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85729
-
Oliver Klee rebased onto patch set 4
V +110/13/25, 11:33 -
core-ci voted on patch set 4 V +1 10/13/25, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86538
-
Markus Klein voted on patch set 4 CR +1 10/13/25, 11:56
-
Georg Ringer voted on patch set 4 CR +1 V +1 10/13/25, 18:54
-
Garvin Hicking commented on patch set 4 10/13/25, 19:44
-
Josef Glatz commented on patch set 4 CR +1 V +1 10/13/25, 19:59
Regarding the decision of whether the class should be declared as internal also in v13, I'm afraid I'll have to pass. From my perspective, the function and code are fine. Correct exit code received. -
Andreas Kienast commented on patch set 4 10/14/25, 05:38
BackendLocker.php:31ReplyFine for me, I don't have any opinion on this. Please feel free to push a new patch set. -
Garvin Hicking commented on patch set 5
CR +1V +110/14/25, 06:26Published edit on patch set 4. -
Garvin Hicking commented on patch set 5 CR +1 V +1 10/14/25, 06:27
BackendLocker.php:31ReplyThanks, done - hope that's fine, but I believe this was the initial intention too, due to the "refactoring" class comment. -
core-ci voted on patch set 5 V +1 10/14/25, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86597
-
Josef Glatz voted on patch set 5 CR +1 V +1 10/14/25, 06:44
-
Markus Klein voted on patch set 5 CR +1 V +1 10/14/25, 08:22
-
Andreas Kienast voted on patch set 5 CR +2 V +2 10/14/25, 09:15
-
Andreas Kienast merged patch set 6 10/14/25, 09:27
BackendLocker.php:31