Review main Merged

90841[BUGFIX] Escape search term in MultipleSideBySide filter

Oli Bartsch CR +2 V +2 Easy +5 −2 updated 10/02/25, 11:12

Commit message

The filter value is now properly escaped
before being passed to RegExp(), preventing
SyntaxError's for usage of special characters.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Oli Bartsch uploaded patch set 1 09/30/25, 08:04

  2. core-ci voted on patch set 1 V +1 09/30/25, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85732

  3. Andreas Kienast commented on patch set 1 09/30/25, 08:20

    select-box-filter.ts:75

    ```suggestion const escapedFilterText = filterText.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'); ```
  4. Oli Bartsch uploaded patch set 2 V +1 09/30/25, 09:37

  5. Oli Bartsch commented on patch set 1 09/30/25, 09:37

    select-box-filter.ts:75 Reply

    Thx. Done.
  6. core-ci voted on patch set 2 V +1 09/30/25, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85741

  7. Benni Mack voted on patch set 2 CR +1 V +1 09/30/25, 09:47

  8. Garvin Hicking commented on patch set 2 CR +1 V +1 10/02/25, 09:54

    (Review note: JavaScript doesn't have preg_quote() for this, this seems to be common practice in JS-world to use that regexp expression)
  9. Oli Bartsch voted on patch set 2 CR +2 V +2 10/02/25, 11:12

  10. Oli Bartsch merged patch set 3 10/02/25, 11:12