Review 13.4 Merged

90842[TASK] Check ReST rendering for commits with .rst files

Garvin Hicking CR +2 V +2 Easy +17 −0 updated 10/01/25, 20:48

Commit message

The nightlies already check the ReST rendering of the full
documentation files since #107514.

However, with a commit like #107519 it became obvious
that ReST rendering checks should better be performed
on pre-merge to avoid wrongly rendered documentation files,
which are directly published on docs.typo3.org after
merge.

The whole rendering process is a step that takes a
little while longer, so unconditionally including it
in pre-merge pipeline steps would take CI longer
than necessary.

This commit introduces pre-merge checking with a rendering
step, but only if a `*.rst` file is included in a commit.

This is done with a `rules` entry which does not allow
to be used in conjunction with `except`, which is why
the current checks are "reworded" to be put into the
`rules` entry.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 46

  1. Garvin Hicking commented on patch set 1 09/30/25, 08:12

    Cherry Picked from branch main.
  2. Garvin Hicking commented on patch set 2 09/30/25, 08:13

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V +1 09/30/25, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85733

  4. core-ci voted on patch set 2 V +1 09/30/25, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85736

  5. Stefan Bürk voted on patch set 2 CR +2 V +2 10/01/25, 20:48

  6. Stefan Bürk merged patch set 3 10/01/25, 20:48