Review main Merged

90844[BUGFIX] Support `maxitems` for StaticSelectFieldType

Oli Bartsch CR +2 V +2 Normal +61 −6 updated 10/01/25, 07:36

Commit message

It has already been possible to define  a
relationship to a static select with the
"relationship" option. However for maximal
backwards compatibility, we still need
to respect "maxitems".

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1114

  1. Oli Bartsch uploaded patch set 1 09/30/25, 09:30

  2. core-ci voted on patch set 1 V +1 09/30/25, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85739

  3. Garvin Hicking commented on patch set 1 09/30/25, 09:42

    ColumnMapFactoryEntityFixture.php:39

    I think this annotation is redundant due to the type declaration and for brevity we could better exclude it (also so that future phpstan levels might not yell at it)
  4. Oli Bartsch uploaded patch set 2 V +1 09/30/25, 09:45

  5. Oli Bartsch commented on patch set 1 09/30/25, 09:45

    ColumnMapFactoryEntityFixture.php:39 Reply

    Done
  6. core-ci voted on patch set 2 V +1 09/30/25, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85742

  7. Nikita Hovratov uploaded patch set 3 V +1 09/30/25, 10:50

  8. Nikita Hovratov voted on patch set 3 CR +1 09/30/25, 10:57

  9. core-ci voted on patch set 3 V +1 09/30/25, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85746

  10. Nikita Hovratov voted on patch set 3 V +1 09/30/25, 11:06

  11. Garvin Hicking voted on patch set 3 CR +1 V +1 09/30/25, 11:08

  12. Oli Bartsch commented on patch set 3 10/01/25, 07:36

    Will merge this now already as it is already a valuable bugfix for itself. In case the reporter has additional use cases, basically another type declaration in the model, which is not covered. I will do another patch.
  13. Oli Bartsch voted on patch set 3 CR +2 V +2 10/01/25, 07:36

  14. Oli Bartsch merged patch set 4 10/01/25, 07:36