Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
90848[FEATURE] Add thumbnail to new record wizard
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 18
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/48/90848/18 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/48/90848/18 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -2 Blocked
- Oli Bartsch -2
-
Verified V -1 Blocked
- core-ci -1 CI
Issues 1
Files 13
- Build/Sources/TypeScript/backend/new-record-wizard.ts6+223 −16
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+14 −0
- typo3/sysext/backend/Resources/Private/Templates/NewContentElement/Wizard.fluid.html+2 −0
- typo3/sysext/backend/Resources/Public/JavaScript/new-record-wizard.js+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/ContentElement/Fixtures/files/file1.pngnew+0 −0
- typo3/sysext/backend/Tests/Functional/Controller/ContentElement/NewContentElementControllerTest.php5+74 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+100 −20
- typo3/sysext/backend/Tests/Unit/Form/Processor/SelectItemProcessorTest.php+44 −0
- typo3/sysext/core/Classes/Schema/Struct/SelectItem.php+20 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-107570-AddThumbnailToNewRecordWizard.rstnew+77 −0
- typo3/sysext/core/Tests/Unit/Schema/Struct/SelectItemTest.php+18 −9
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+7 −4
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php+4 −2
Review log 4664
Show 2739 earlier messages
-
Dennis Purisevic uploaded patch set 1 09/30/25, 14:58
-
core-ci voted on patch set 1 V -1 09/30/25, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85750
-
Oliver Klee updated the commit message in patch set 2
V -109/30/25, 15:07 -
core-ci voted on patch set 2 V -1 09/30/25, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85751
-
Garvin Hicking commented on patch set 2 09/30/25, 17:24
(have not checked yet, just some spelling remarks) I already wondered about if this wizard could have some kind of preview. First I thought to be able to use HTML to align it with the backend preview in the Page Layout. But that might take up much room and be slower to render. So maybe a thumbnail is better - I wonder tbough if integrators will update their screenshots when content modules change.Feature-107570-AddThumbnailToNewRecordWizard.rst:24```suggestion A new view selector has been introduces. This allowes the user to choose between ```Feature-107570-AddThumbnailToNewRecordWizard.rst:25```suggestion a list view (1 column) and a grid view (up to 3 columns). Optionally, it is ```Feature-107570-AddThumbnailToNewRecordWizard.rst:26Maybe we should have a User TSConfig setting that can set defaults for this view? (note to self: Haven't checked yet - is the selected viewmode persistently stored somewhere, or does it reset to default state)Feature-107570-AddThumbnailToNewRecordWizard.rst:34```suggestion The thumbnail path can be either an extension path ``` -
Simon Schaufelberger commented on patch set 2 09/30/25, 19:47
new-record-wizard.ts:626I think there is a bootstrap utility class available: w-100new-record-wizard.ts:908to use proper xhtml, add a closing "/" pleaseNewContentElementControllerTest.php:131Why is this a nested array? I would expect thumbnail -> fileadmin... -
Dennis Purisevic uploaded patch set 3
V -110/01/25, 06:44 -
Dennis Purisevic updated the commit message in patch set 4 10/01/25, 06:45
-
Dennis Purisevic commented on patch set 4 10/01/25, 06:45
new-record-wizard.ts:626ReplyDonenew-record-wizard.ts:908ReplyDoneNewContentElementControllerTest.php:131ReplyThe idea behind this was that if additional attributes such as alt, width, height, or others needed to be added in the future, this would already be prepared. Should I keep it as an array or convert it to a string?Feature-107570-AddThumbnailToNewRecordWizard.rst:24ReplyDoneFeature-107570-AddThumbnailToNewRecordWizard.rst:25ReplyDoneFeature-107570-AddThumbnailToNewRecordWizard.rst:26ReplyThe viewmode is stored in the browser's session storage, just like the selected category. Therefore, the display mode will be reset at some point in time. I hadn't thought of that. But I can see that a TSConfig setting for users would be useful for specifying a default viewmode. If someone doesn't want the thumbnail view to be displayed or always the list view, they can set this. I will add that.Feature-107570-AddThumbnailToNewRecordWizard.rst:34ReplyDone -
core-ci voted on patch set 3 V -1 10/01/25, 06:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85778
-
core-ci voted on patch set 4 V -1 10/01/25, 06:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85779
-
Dennis Purisevic uploaded patch set 5
V -110/01/25, 07:05 -
core-ci voted on patch set 5 V +1 10/01/25, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85781
-
Dennis Purisevic commented on patch set 5 10/01/25, 07:15
NewContentElementControllerTest.php:205What do you think about this? I have no idea how else I could do it. -
Oli Bartsch commented on patch set 5 10/01/25, 08:52
Hi Dennis, thanks a lot for your work in this area. I really appreciate the initiative to improve the record creation process. There have already been some steps in this direction (https://review.typo3.org/c/Packages/TYPO3.CMS/+/77258) and the ongoing “creation wizard” effort (https://review.typo3.org/c/Packages/TYPO3.CMS/+/83208), so it’s great to see more progress here. That said, I think we should first develop a complete concept, ideally together with the UX team, and also outline the technical requirements. A few points to consider: - We usually avoid importing Bootstrap components directly into TYPO3 components. - Thumbnail sizes are not yet defined. The wizard has multiple use cases (not only for new records, but also dashboard widgets, form elements, etc.). Introducing thumbnails and offering different view variants should ideally be treated as separate changes. I’d suggest continuing this discussion in Slack, preferably in #cig-ux, so we can align on concept and requirements before moving ahead. -
Simon Schaufelberger commented on patch set 5 10/01/25, 10:18
Reply
@bo@cedev.de The whole idea came actually out of a post in Slack in the UX channel, see https://typo3.slack.com/archives/C027S88NY/p1752697812992599 -
Simon Schaufelberger commented on patch set 5 10/01/25, 10:19
-
Oli Bartsch commented on patch set 5 10/01/25, 12:14
Reply
That's great. So we can work out a concept there. It seems someone already did some mockups. -
Benni Mack marked it work in progress 10/09/25, 13:04
-
Dennis Purisevic uploaded patch set 6
V +111/03/25, 15:18 -
core-ci voted on patch set 6 V -1 11/03/25, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88390
-
Dennis Purisevic uploaded patch set 7
V -111/03/25, 15:52 -
core-ci voted on patch set 7 V +1 11/03/25, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88393
-
Dennis Purisevic uploaded patch set 8
V +111/03/25, 16:11 -
core-ci voted on patch set 8 V +1 11/03/25, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88397
-
Dennis Purisevic marked it ready for review 11/03/25, 16:19
-
Dennis Purisevic commented on patch set 8 11/03/25, 16:20
Reply
@bo@cedev.de "We usually avoid importing Bootstrap components directly into TYPO3 components." Yes, I already thought so, but the problem is that when the wizard is rendered, bootstrap already initialized, so the drop-down menu has to be initialized again. Do you have any idea how this can be solved? If not, I'll ask in Slack.NewContentElementControllerTest.php:131ReplyDoneNewContentElementControllerTest.php:205ReplyDoneFeature-107570-AddThumbnailToNewRecordWizard.rst:26ReplyDone -
Simon Schaufelberger commented on patch set 8 11/03/25, 17:10
new-record-wizard.ts:661remove debug -
Oli Bartsch commented on patch set 8 11/03/25, 17:12
Reply
Not quite sure right now. You might want to as @benjamin.kott@outlook.com or @ben@bnf.dev. -
Dennis Purisevic uploaded patch set 9
V +111/20/25, 11:15 -
Dennis Purisevic commented on patch set 9 11/20/25, 11:18
Reply
Since I haven't received any feedback via Slack or here, there is currently no solution for this. I have added two comments as TODO items so that this can be adjusted in the future. I hope that's okay.new-record-wizard.ts:661ReplyGood catch. Removed. -
core-ci voted on patch set 9 V -1 11/20/25, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90266
-
Dennis Purisevic uploaded patch set 10
V -111/21/25, 15:31 -
core-ci voted on patch set 10 V +1 11/21/25, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90537
-
Dennis Purisevic uploaded patch set 11
V +101/09/26, 17:13 -
core-ci voted on patch set 11 V -1 01/09/26, 17:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93161
-
Dennis Purisevic uploaded patch set 12
V -101/09/26, 17:28 -
core-ci voted on patch set 12 V +1 01/09/26, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93163
-
Georg Ringer commented on patch set 12 01/10/26, 08:31
should we also add it to \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerPlugin? if not it should also be mentioned and why not
-
Dennis Purisevic commented on patch set 12 01/10/26, 09:23
Reply
I hadn't thought about that, but it makes sense. I'll add that -
Dennis Purisevic uploaded patch set 13
V +101/10/26, 09:58 -
core-ci voted on patch set 13 V +1 01/10/26, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93198
-
Dennis Purisevic uploaded patch set 14
V +101/10/26, 11:51 -
core-ci voted on patch set 14 V +1 01/10/26, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93201
-
Simon Schaufelberger voted on patch set 14 CR +1 V +1 01/10/26, 16:28
-
Dennis Purisevic uploaded patch set 15
CR +1V +102/05/26, 06:06 -
core-ci voted on patch set 15 V -1 02/05/26, 06:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95104
-
Dennis Purisevic uploaded patch set 16
V -102/05/26, 09:41 -
core-ci voted on patch set 16 V +1 02/05/26, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95120
-
Dennis Purisevic uploaded patch set 17
V +102/09/26, 08:54 -
core-ci voted on patch set 17 V +1 02/09/26, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95447
-
Anja Leichsenring commented on patch set 17 02/20/26, 19:29
please add the userTS configuration snippet to the Feature.rst file. -
Anja Leichsenring commented on patch set 17 02/20/26, 19:40
Reply
ah sorry, found it. Too eager to test, sorry for the disturbance. -
Anja Leichsenring voted on patch set 17 CR +1 V +1 02/20/26, 19:47
-
Oli Bartsch commented on patch set 17 CR -2 02/20/26, 21:52
Hi, I’m sorry, but due to recent votes I have to set this to -2. We’ve decided not to include this feature in v14 for several reasons, including: - The patch lacks a clear overall concept. - The implementation does not follow current best practices. For example, fixed image dimensions are not future-proof; SVG or similar approaches should be used instead. - We are currently working on a new wizard component that may directly replace the functionality proposed in this patch. -
Simon Schaufelberger commented on patch set 17 02/20/26, 22:06
Reply
@bo@cedev.de I have to disagree with all of your points. - There has been a long discussion in Slack already and even several mockups: https://typo3.slack.com/archives/C027S88NY/p1752697812992599 - SVGs can actually be used. For actual preview images it would be better to use actual images instead. - I don't think this new wizard will be completely different. This new wizard will hopefully also allow thumbnails of the content element - The current SVGs icons are a terrible way to give the user any glue how the content element will look like - I'm using this patch already on my own website and gave Dennis some valuable feedback. I would say until there is no better concept that the core team provides, this is a good solution. -
Oli Bartsch commented on patch set 17 02/20/26, 22:33
Reply
We discussed this patch several times with various people from the Core and other teams. As mentioned before, we decided not to include it in v14. None of the arguments presented so far justify merging the patch in its current state. I think it’s acceptable to disagree on this. -
Dennis Purisevic commented on patch set 17 03/09/26, 08:56
Reply
That's a bummer. Should I abandon the patch and close the forge issue? -
Simon Schaufelberger commented on patch set 17 03/09/26, 09:15
Reply
I would leave it open. Maybe it will make it into v15? -
Simon Schaufelberger commented on patch set 17 03/09/26, 09:16
Reply Unresolved
I will keep on rebasing and composer patch my installation to use this feature because I really like it! -
Anja Leichsenring voted on patch set 17 CR 0 V 0 03/10/26, 19:41
-
Simon Schaufelberger uploaded patch set 18
V +109/08/26, 15:51Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Simon Schaufelberger commented on patch set 18 09/08/26, 15:53
Unresolved
@bo@cedev.de I would like to bring up this topic again. Can we have a preview image in the core. This would be so much better than just a little svg icon. -
core-ci voted on patch set 18 V -1 09/08/26, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108102