Review main Merged

90850[BUGFIX] Fix missing labels in extension configuration

TYPO3com CR +2 V +2 Easy +11 −6 updated 06/12/26, 08:02

Commit message

This patch brings back the use of labels to display
customcategory in extension configuration

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1424

  1. TYPO3com uploaded patch set 1 09/30/25, 20:37

  2. core-ci voted on patch set 1 V -1 09/30/25, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85760

  3. Garvin Hicking updated the commit message in patch set 2 V -1 09/30/25, 20:49

  4. Garvin Hicking commented on patch set 3 09/30/25, 20:54

    Published edit on patch set 2.
  5. core-ci voted on patch set 3 V -1 09/30/25, 21:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85762

  6. core-ci voted on patch set 2 V -1 09/30/25, 21:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85761

  7. Rémi Payette commented on patch set 4 V -1 09/30/25, 21:23

    Published edit on patch set 3.
  8. Rémi Payette commented on patch set 5 09/30/25, 21:25

    Published edit on patch set 4.
  9. core-ci voted on patch set 4 V -1 09/30/25, 21:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85764

  10. core-ci voted on patch set 5 V -1 09/30/25, 21:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85765

  11. Rémi Payette commented on patch set 6 V -1 09/30/25, 21:37

    Published edit on patch set 5.
  12. core-ci voted on patch set 6 V +1 09/30/25, 21:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85766

  13. Stefan Bürk commented on patch set 6 10/01/25, 09:41

    ExtensionForm.html:41

    ```suggestion {category.label ? category.label : categoryName} ``` In case a empty label is provided or an invalid translation key leading to an empty string there would be no display in the tab, which looks ugly and is kind of wrong. We should use the categoryName as fallback in this case here to have still a meaningfull tab label in place. What do you think ?
  14. Rémi Payette commented on patch set 7 V +1 10/01/25, 14:10

    Published edit on patch set 6.
  15. core-ci voted on patch set 7 V +1 10/01/25, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85825

  16. Benni Mack updated the commit message in patch set 8 V +1 04/22/26, 06:31

  17. core-ci voted on patch set 8 V -1 04/22/26, 07:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100721

  18. Christian Kuhn commented on patch set 8 06/11/26, 22:15

    ExtensionForm.html:41 Reply

    Done
  19. Christian Kuhn uploaded patch set 9 V -1 06/11/26, 22:21

  20. Christian Kuhn commented on patch set 9 CR +1 V +1 06/11/26, 22:22

    uh, that took a while. patch is correct. rebased.
  21. Christian Kuhn commented on patch set 9 06/11/26, 22:23

    thank you!
  22. core-ci voted on patch set 9 V +1 06/11/26, 22:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103413

  23. Stefan Bürk voted on patch set 9 CR +2 V +2 06/12/26, 07:52

  24. Stefan Bürk merged patch set 10 06/12/26, 08:02