90851[TASK] Migrate ExecuteSchedulableCommandTask
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 15
- typo3/sysext/core/Classes/Console/CommandRegistry.php2+12 −0
- typo3/sysext/core/Tests/Unit/DependencyInjection/ConsoleCommandPassTest.php+1 −1
- typo3/sysext/scheduler/Classes/EventListener/AddSchedulableCommandsAsNativeTaskTypes.php2new+75 −0
- typo3/sysext/scheduler/Classes/Form/Element/SchedulableCommandConfigurationElement.phpnew+223 −0
- typo3/sysext/scheduler/Classes/Hooks/SchedulerTaskPersistenceValidator.php2+45 −0
- typo3/sysext/scheduler/Classes/Migration/SchedulerDatabaseStorageMigration.php+8 −3
- typo3/sysext/scheduler/Classes/Service/TaskService.php+9 −21
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.phpdeleted+0 −388
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandTask.php+70 −37
- typo3/sysext/scheduler/Resources/Private/Language/locallang.xlf+12 −0
- typo3/sysext/scheduler/Resources/Private/Templates/CommandConfiguration.htmlnew+67 −0
- typo3/sysext/scheduler/Tests/Functional/Fixtures/DatabaseStorageMigrationApplied.csvbinary
- typo3/sysext/scheduler/Tests/Functional/Fixtures/DatabaseStorageMigrationBase.csvbinary
- typo3/sysext/scheduler/Tests/Functional/Task/ExecuteSchedulableCommandAdditionalFieldProviderTest.phpdeleted+0 −74
- typo3/sysext/scheduler/ext_localconf.php+7 −10
Review log 1521
-
Oli Bartsch uploaded patch set 1 09/30/25, 20:56
-
core-ci voted on patch set 1 V +1 09/30/25, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85763
-
Oli Bartsch uploaded patch set 2
V +110/01/25, 09:15 -
core-ci voted on patch set 2 V +1 10/01/25, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85795
-
Oli Bartsch uploaded patch set 3
V +110/01/25, 09:29 -
core-ci voted on patch set 3 V +1 10/01/25, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85796
-
Garvin Hicking commented on patch set 3 10/01/25, 09:53
Appliying this patch puts all symfony commands in to the "scheduler" section of the Task wizard. I did enjoy having the tasks listed in their own section domain spaces before the change. Screenshots with patch: https://www.dropbox.com/scl/fi/5pd4rt5ocjr1gsg3d9eb9/Screenshot-2025-10-01-at-11.52.48.png?rlkey=cnzn4whf8m7ijnbp4e7xntn9h&dl=0 Screenshot before patch: https://www.dropbox.com/scl/fi/7uqv3b4943pmwgppprxej/Screenshot-2025-10-01-at-11.53.23.png?rlkey=wra4lvdmtwwhdgy6abumgy4u8&dl=0 -
Simon Schaufelberger commented on patch set 3 10/01/25, 09:58
AddSchedulableCommandsAsNativeTaskTypes.php:31Usually the event listener also gets an identifier. Wouldn't it be good to add one here?SchedulerTaskPersistenceValidator.php:49since you are already adjusting this file, you could also add an empty line here to fix code style. -
Oli Bartsch uploaded patch set 4
V +110/01/25, 11:42 -
Oli Bartsch commented on patch set 4 10/01/25, 11:43
Reply
Good Point! Thanks.AddSchedulableCommandsAsNativeTaskTypes.php:31ReplyI tend to avoid any specific identifier with no further purpose. The service name is taken automatically as identifier. This should be sufficient here.SchedulerTaskPersistenceValidator.php:49ReplyDone -
core-ci voted on patch set 4 V -1 10/01/25, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85809
-
Oli Bartsch uploaded patch set 5
V -110/01/25, 12:16 -
core-ci voted on patch set 5 V +1 10/01/25, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85813
-
Benni Mack commented on patch set 5 10/01/25, 12:34
CommandRegistry.php:80I suggest to create a new method and we can add a comment "Core does not use this anymore, consider deprecation" for a separate patch -
Oli Bartsch uploaded patch set 6
V +110/01/25, 12:44 -
Oli Bartsch commented on patch set 6 10/01/25, 12:44
CommandRegistry.php:80ReplyDone -
core-ci voted on patch set 6 V +1 10/01/25, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85816
-
Garvin Hicking commented on patch set 6 CR +1 V +1 10/01/25, 13:00
Thanks! The tests I've made seem to work out alright, migration is performed. Lovely! -
Georg Ringer voted on patch set 6 CR +1 V +1 10/01/25, 13:30
-
Benni Mack voted on patch set 6 CR +2 V +2 10/01/25, 13:32
-
Benni Mack merged patch set 7 10/01/25, 13:32