Review main Merged

90851[TASK] Migrate ExecuteSchedulableCommandTask

Oli Bartsch CR +2 V +2 Expert +529 −534 updated 10/01/25, 13:32

Commit message

This migrates the `ExecuteSchedulableCommandTask`
scheduler task. As a result, all schedulable
commands are now registered as native TCA types.

They are added directly via a PSR-14 Event.

Available arguments and options are now
rendered via the new dedicated TCA renderType
`schedulableCommandConfiguration`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 15

Review log 1521

  1. Oli Bartsch uploaded patch set 1 09/30/25, 20:56

  2. core-ci voted on patch set 1 V +1 09/30/25, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85763

  3. Oli Bartsch uploaded patch set 2 V +1 10/01/25, 09:15

  4. core-ci voted on patch set 2 V +1 10/01/25, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85795

  5. Oli Bartsch uploaded patch set 3 V +1 10/01/25, 09:29

  6. core-ci voted on patch set 3 V +1 10/01/25, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85796

  7. Garvin Hicking commented on patch set 3 10/01/25, 09:53

    Appliying this patch puts all symfony commands in to the "scheduler" section of the Task wizard. I did enjoy having the tasks listed in their own section domain spaces before the change. Screenshots with patch: https://www.dropbox.com/scl/fi/5pd4rt5ocjr1gsg3d9eb9/Screenshot-2025-10-01-at-11.52.48.png?rlkey=cnzn4whf8m7ijnbp4e7xntn9h&dl=0 Screenshot before patch: https://www.dropbox.com/scl/fi/7uqv3b4943pmwgppprxej/Screenshot-2025-10-01-at-11.53.23.png?rlkey=wra4lvdmtwwhdgy6abumgy4u8&dl=0
  8. Simon Schaufelberger commented on patch set 3 10/01/25, 09:58

    AddSchedulableCommandsAsNativeTaskTypes.php:31

    Usually the event listener also gets an identifier. Wouldn't it be good to add one here?

    SchedulerTaskPersistenceValidator.php:49

    since you are already adjusting this file, you could also add an empty line here to fix code style.
  9. Oli Bartsch uploaded patch set 4 V +1 10/01/25, 11:42

  10. Oli Bartsch commented on patch set 4 10/01/25, 11:43

    Reply

    Good Point! Thanks.

    AddSchedulableCommandsAsNativeTaskTypes.php:31 Reply

    I tend to avoid any specific identifier with no further purpose. The service name is taken automatically as identifier. This should be sufficient here.

    SchedulerTaskPersistenceValidator.php:49 Reply

    Done
  11. core-ci voted on patch set 4 V -1 10/01/25, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85809

  12. Oli Bartsch uploaded patch set 5 V -1 10/01/25, 12:16

  13. core-ci voted on patch set 5 V +1 10/01/25, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85813

  14. Benni Mack commented on patch set 5 10/01/25, 12:34

    CommandRegistry.php:80

    I suggest to create a new method and we can add a comment "Core does not use this anymore, consider deprecation" for a separate patch
  15. Oli Bartsch uploaded patch set 6 V +1 10/01/25, 12:44

  16. Oli Bartsch commented on patch set 6 10/01/25, 12:44

    CommandRegistry.php:80 Reply

    Done
  17. core-ci voted on patch set 6 V +1 10/01/25, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85816

  18. Garvin Hicking commented on patch set 6 CR +1 V +1 10/01/25, 13:00

    Thanks! The tests I've made seem to work out alright, migration is performed. Lovely!
  19. Georg Ringer voted on patch set 6 CR +1 V +1 10/01/25, 13:30

  20. Benni Mack voted on patch set 6 CR +2 V +2 10/01/25, 13:32

  21. Benni Mack merged patch set 7 10/01/25, 13:32