Review main Merged

90862[TASK] Migrate ValidatorTask to native task

Oli Bartsch CR +2 V +2 Hard +270 −555 updated 10/02/25, 09:20

Commit message

This migrates the EXT:linkvalidator `ValidatorTask`
scheduler task to a native TCA type.

New DB fields related to this task are prefixed with
`tx_linkvalidator`, marking best practice for custom
fields outside of the scheduler extension.

Down the road, some side quests are handled as well:

* "Run On CLI" info is not shown for not persisted records.
* TaskTypeInfoElement is directly accessing task info via the
  corresponding task service method.
* Specific native task validation (necessary due to FormEngine
  limitations) is done in the task directly now and
  resolved by the DataHandler hook via a method_exists check
  and call.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 13

Review log 2029

Show 24 earlier messages
  1. Oli Bartsch uploaded patch set 1 10/01/25, 21:26

  2. core-ci voted on patch set 1 V -1 10/01/25, 21:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85844

  3. Oli Bartsch uploaded patch set 2 V -1 10/02/25, 06:45

  4. core-ci voted on patch set 2 V -1 10/02/25, 06:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85866

  1. Oli Bartsch uploaded patch set 3 V -1 10/02/25, 07:26

  2. core-ci voted on patch set 3 V -1 10/02/25, 07:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85876

  3. Oli Bartsch uploaded patch set 4 V -1 10/02/25, 07:58

  4. core-ci voted on patch set 4 V +1 10/02/25, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85879

  5. Oli Bartsch uploaded patch set 5 V +1 10/02/25, 08:08

  6. Oli Bartsch uploaded patch set 6 10/02/25, 08:08

  7. core-ci voted on patch set 6 V +1 10/02/25, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85883

  8. Benni Mack uploaded patch set 7 V +1 10/02/25, 08:25

  9. Benni Mack uploaded patch set 8 10/02/25, 08:31

  10. core-ci voted on patch set 7 V +1 10/02/25, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85886

  11. core-ci voted on patch set 8 V +1 10/02/25, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85887

  12. Benni Mack voted on patch set 8 CR +1 V +1 10/02/25, 08:37

  13. Christian Kuhn voted on patch set 8 CR +1 V +1 10/02/25, 08:47

  14. Garvin Hicking commented on patch set 8 10/02/25, 08:50

    ValidatorTask.php:378

    ```suggestion $page = $this->extractPageId($parameters); ```

    ValidatorTask.php:457

    ```suggestion protected function extractPageId(array $parameters): int ```
  15. Garvin Hicking voted on patch set 8 CR -1 10/02/25, 08:50

  16. Oli Bartsch commented on patch set 9 CR +1 V +1 10/02/25, 08:51

    Published edit on patch set 8.
  17. Garvin Hicking commented on patch set 9 CR +1 V +1 10/02/25, 08:58

    Cheerio, Mrs. Schedulerio!
  18. core-ci voted on patch set 9 V -1 10/02/25, 08:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85889

  19. Oli Bartsch uploaded patch set 10 CR +1 V +1 10/02/25, 09:00

  20. core-ci voted on patch set 10 V +1 10/02/25, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85890

  21. Oli Bartsch commented on patch set 10 10/02/25, 09:09

    ValidatorTask.php:378 Reply

    Fix applied.

    ValidatorTask.php:457 Reply

    Fix applied.
  22. Benni Mack voted on patch set 10 CR +1 V +1 10/02/25, 09:14

  23. Christian Kuhn voted on patch set 10 CR +1 V +1 10/02/25, 09:20

  24. Oli Bartsch voted on patch set 10 CR +2 V +2 10/02/25, 09:20

  25. Oli Bartsch merged patch set 11 10/02/25, 09:20