Review main Merged

90863[BUGFIX] Correct closing tag of typo3-formengine-valueslider

Benjamin Kott CR +2 V +2 Easy +1 −1 updated 10/02/25, 07:03

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1214

  1. Benjamin Kott uploaded patch set 1 10/02/25, 05:22

  2. Garvin Hicking voted on patch set 1 CR +1 V +1 10/02/25, 05:35

  3. core-ci voted on patch set 1 V +1 10/02/25, 05:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85857

  4. Garvin Hicking commented on patch set 1 10/02/25, 05:38

    maybe 12.4 too, even though no priority it shouldn't hurt to fix this markup?
  5. Georg Ringer voted on patch set 1 CR +1 V +1 10/02/25, 05:49

  6. Benjamin Kott commented on patch set 1 10/02/25, 06:01

    Reply

    sure i just checked wrong, looked like it was introduced in v13
  7. Benjamin Kott updated the commit message in patch set 2 CR +1 V +1 10/02/25, 06:02

  8. Benjamin Kott commented on patch set 2 10/02/25, 06:02

    Reply

    Done
  9. core-ci voted on patch set 2 V +1 10/02/25, 06:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85863

  10. Georg Ringer voted on patch set 2 CR +1 V +1 10/02/25, 06:11

  11. Benni Mack voted on patch set 2 CR +1 V +1 10/02/25, 06:21

  12. Garvin Hicking voted on patch set 2 CR +1 V +1 10/02/25, 06:33

  13. Benjamin Kott voted on patch set 2 CR +2 V +2 10/02/25, 06:50

  14. Benjamin Kott merged patch set 3 10/02/25, 07:03