Review main Merged

90864[TASK] Use attribute selectors instead of pseudo-classes for disabled and readonly

Benjamin Kott CR +2 V +2 Normal +67 −71 updated 10/02/25, 14:50

Commit message

Replace all occurrences of :disabled and :readonly with their
corresponding attribute selectors ([disabled] and [readonly]).

Pseudo-class selectors are handled internally by browsers and cannot
be implemented in custom web components. Since the state of these
elements is always reflected in their attributes, this change has no
impact on current implementations and serves as a preparation for
future work.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 68

  1. Benjamin Kott uploaded patch set 1 10/02/25, 05:35

  2. core-ci voted on patch set 1 V +1 10/02/25, 05:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85859

  3. Benjamin Kott uploaded patch set 2 V +1 10/02/25, 07:05

  4. core-ci voted on patch set 2 V +1 10/02/25, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85871

  5. Benjamin Franzke voted on patch set 2 CR +1 V +1 10/02/25, 11:57

  6. Benni Mack voted on patch set 2 CR +1 V +1 10/02/25, 13:09

  7. Benjamin Kott voted on patch set 2 CR +2 V +2 10/02/25, 13:38

  8. Benjamin Kott merged patch set 3 10/02/25, 14:50