Review main Abandoned

90867[TASK] Prevent using Symfony 7.3 syntax for Symfony Validators

Garvin Hicking CR 0 V -1 Easy +2 −1 updated 10/02/25, 11:00

Commit message

Review

  • Code review CR 0
  • Verified V -1
    • Garvin Hicking -1
    • core-ci +1 CI

Issues 2

Files 1

Review log 46

  1. Garvin Hicking uploaded patch set 1 10/02/25, 06:17

  2. core-ci voted on patch set 1 V +1 10/02/25, 06:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85864

  3. core-ci commented on patch set 1 10/02/25, 06:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85865

  4. Garvin Hicking commented on patch set 1 V -1 10/02/25, 06:40

    Unresolved

    Need to check on something
  5. Garvin Hicking commented on patch set 1 10/02/25, 06:50

    This "IdentityValidator" replacement for setting ->translationDomain=false does not actually lead to the same code branch than on 7.3. Will need to check with Elias how this can be salvaged, or if a raise to Symfony 7.3 is safer.
  6. Garvin Hicking abandoned the change 10/02/25, 11:00

    Abandoned, using Symfony 7.3 instead.