Review main Merged

90879[TASK] Upgrade to CKEditor 5 47.0.0

Garvin Hicking CR +2 V +2 Expert +792 −786 updated 10/09/25, 12:58

Commit message

CKEditor 5 47.0.0 has minor bugfixes and smaller breaking
changes that should not be relevant to TYPO3 integrations.

The main feature is the possibility for using a commercial
AI plugin (not bundled), which is now in "early access".

CKEditor 5 v47 will be a LTS release with support of 3
years.

Further info: https://github.com/ckeditor/ckeditor5/releases/tag/v47.0.0

Used commands:

  cd Build
  npm --prefix overrides/ckeditor5 version 47.0.0
  npm install --save ./overrides/ckeditor5 $(
    grep @ckeditor/ package.json | \
    grep -v @ckeditor/ckeditor5-dev-utils | \
    grep -v @ckeditor/ckeditor5-inspector | \
    sed 's/^[^"]*"\([^"]*\)".*/\1@47.0.0/' \
  )
  npm install --save @ckeditor/ckeditor5-icons@^47.0.0
  npm install --save @ckeditor/ckeditor5-inspector@^5.0.0
  npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 79

  1. Garvin Hicking uploaded patch set 1 10/02/25, 11:40

  2. core-ci voted on patch set 1 V +1 10/02/25, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85913

  3. Garvin Hicking updated the commit message in patch set 2 V +1 10/02/25, 11:49

  4. core-ci voted on patch set 2 V +1 10/02/25, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85915

  5. Benjamin Franzke commented on patch set 2 CR +1 V +1 10/02/25, 12:57

    I just noticed that a link to a hidden page is not "unlinkable" once the RTE contents were loaded from DB, because the link attribute `data-rte-error` is not correctly removed. But this is also broken with v45 and v46 (possibly because of the link button migration back then), so i'll vote +1 here, as this will need to be fixed separately.
  6. Benjamin Franzke commented on patch set 2 10/07/25, 09:00

    Reply

    Fix is here: > https://review.typo3.org/c/Packages/TYPO3.CMS/+/90938 [BUGFIX] Fix unlinking of anchors to hidden or deleted pages in RTE [NEW]
  7. Benni Mack voted on patch set 2 CR +1 V +1 10/09/25, 12:32

  8. Benjamin Franzke voted on patch set 2 CR +2 V +2 10/09/25, 12:43

  9. Benjamin Franzke merged patch set 3 10/09/25, 12:58