90886[BUGFIX] Support iconOverlay in SelectItem
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Benni Mack +1
- core-ci +1 CI
Issues 5
- Bug #107594Allow iconOverlay in SelectItem
- Feature #102834Auto-registration of NewContentElementWizard via TCA
- Bug #105253iconOverlay Option in newContentElementWizard does not work anymore
- Task #100065Migrate NewContentElementWizard to lit
- Task #92942[FEATURE] Allow icon overlay for newContentElementWizard
Files 8
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+1 −0
- typo3/sysext/backend/Tests/Functional/Controller/ContentElement/NewContentElementControllerTest.php+16 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+89 −20
- typo3/sysext/backend/Tests/Unit/Form/Processor/SelectItemProcessorTest.php+44 −0
- typo3/sysext/core/Classes/Schema/Struct/SelectItem.php2+20 −0
- typo3/sysext/core/Documentation/Changelog/13.4.x/Important-107594-IconOverlayForNewContentElementWizardViaSelectItems.rstnew+88 −0
- typo3/sysext/core/Tests/Unit/Schema/Struct/SelectItemTest.php+15 −9
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+7 −4
Review log 912
-
Oli Bartsch uploaded patch set 1 10/02/25, 21:15
-
core-ci voted on patch set 1 V -1 10/02/25, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85943
-
Stefan Bürk commented on patch set 1 10/02/25, 21:29
TCA SelectItem `iconOverlay` only has an effect for the new content element wizard, correct ? Other places rendering "TCA Select Item icons" does not do the overlay (yet) ?SelectItem.php:225What is the reason to add an wither for icon overlay soley for the icon overlay ? This is not done for any of the other properties nor providing single setter. Should we really start mixing this ? Or is this more for "usage" aka "php" api when using the TCA SelectItem object in custom code to "change"/add an overlay icon ? The wither is not explained in commit message or the important rest file. -
Oli Bartsch uploaded patch set 2
V -110/03/25, 09:10 -
core-ci voted on patch set 2 V -1 10/03/25, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85957
-
Oli Bartsch uploaded patch set 3
V -110/03/25, 09:31 -
Oli Bartsch commented on patch set 3 10/03/25, 09:31
Reply
Correct it is added as bugfix to support overlays for wizard items when auto configuration is used (which is the default). More usages can and will be added over time. E.g. I already prepare a patch for scheduler tasks.SelectItem.php:225ReplyThe class is using `with*()` for all select related properties: "label", "value", "icon", etc. For consistency in the API for TCA type "select", I've added it for `$iconOverlay` as well. -
core-ci voted on patch set 3 V +1 10/03/25, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85958
-
Georg Ringer voted on patch set 3 CR +1 V +1 10/03/25, 09:56
-
Benni Mack voted on patch set 3 CR +1 V +1 10/04/25, 15:11
-
Oli Bartsch voted on patch set 3 CR +2 V +2 10/04/25, 15:47
-
Oli Bartsch merged patch set 4 10/04/25, 15:48