Review main Merged

90886[BUGFIX] Support iconOverlay in SelectItem

Oli Bartsch CR +2 V +2 Hard +280 −33 updated 10/04/25, 15:48

Commit message

The ability to define an icon overlay
for items in the “New Content Element”
wizard was introduced in #92942, accidentally
removed during the web-component migration
in #100065, and restored in #105253.

In the meantime, #102834 added auto-registration
of wizard items from TCA, defining overlays
in Page TSconfig remains supported but is
no longer recommended, as it duplicates
configuration

Therefore, the SelectItem component now
supports an iconOverlay option, enabling
icon overlays for wizard items auto-registered
via TCA.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 5

Files 8

Review log 912

  1. Oli Bartsch uploaded patch set 1 10/02/25, 21:15

  2. core-ci voted on patch set 1 V -1 10/02/25, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85943

  3. Stefan Bürk commented on patch set 1 10/02/25, 21:29

    TCA SelectItem `iconOverlay` only has an effect for the new content element wizard, correct ? Other places rendering "TCA Select Item icons" does not do the overlay (yet) ?

    SelectItem.php:225

    What is the reason to add an wither for icon overlay soley for the icon overlay ? This is not done for any of the other properties nor providing single setter. Should we really start mixing this ? Or is this more for "usage" aka "php" api when using the TCA SelectItem object in custom code to "change"/add an overlay icon ? The wither is not explained in commit message or the important rest file.
  4. Oli Bartsch uploaded patch set 2 V -1 10/03/25, 09:10

  5. core-ci voted on patch set 2 V -1 10/03/25, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85957

  6. Oli Bartsch uploaded patch set 3 V -1 10/03/25, 09:31

  7. Oli Bartsch commented on patch set 3 10/03/25, 09:31

    Reply

    Correct it is added as bugfix to support overlays for wizard items when auto configuration is used (which is the default). More usages can and will be added over time. E.g. I already prepare a patch for scheduler tasks.

    SelectItem.php:225 Reply

    The class is using `with*()` for all select related properties: "label", "value", "icon", etc. For consistency in the API for TCA type "select", I've added it for `$iconOverlay` as well.
  8. core-ci voted on patch set 3 V +1 10/03/25, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85958

  9. Georg Ringer voted on patch set 3 CR +1 V +1 10/03/25, 09:56

  10. Benni Mack voted on patch set 3 CR +1 V +1 10/04/25, 15:11

  11. Oli Bartsch voted on patch set 3 CR +2 V +2 10/04/25, 15:47

  12. Oli Bartsch merged patch set 4 10/04/25, 15:48