Review main Merged

90890[TASK] Update phpstan to 2.1.30

Garvin Hicking CR +2 V +2 Easy +20 −13 updated 10/04/25, 09:36

Commit message

Executed commands:

    composer req --dev phpstan/phpstan:^2.1.30 -W
   ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Two entries are added to the baseline that will hopefully
be removed again at some point in a future PHPStan release.

The future 2.1.30 will likely notify us about that with
a nightly "phpstan max" error that removes these entries.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Chris Müller +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1520

  1. Garvin Hicking uploaded patch set 1 10/03/25, 18:55

  2. core-ci voted on patch set 1 V -1 10/03/25, 19:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85962

  3. Garvin Hicking uploaded patch set 2 V -1 10/04/25, 07:53

  4. core-ci voted on patch set 2 V +1 10/04/25, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85983

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 10/04/25, 08:24

  6. Stefan Bürk commented on patch set 2 CR 0 V 0 10/04/25, 08:26

    Update should use ``` composer req --dev phpstan/phpstan:^2.1.30 -W ``` directly. Same for backports.
  7. Garvin Hicking updated the commit message in patch set 3 V +1 10/04/25, 08:29

  8. Garvin Hicking commented on patch set 3 10/04/25, 08:29

    Reply

    copy pasta
  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/04/25, 08:36

  10. Chris Müller voted on patch set 3 CR +1 V +1 10/04/25, 08:38

  11. Stefan Bürk commented on patch set 3 CR -1 10/04/25, 08:38

    Reply

    Not only commit message, the changed command needs to be executed. Update in `composer.json` is missing and not reflecting the executed require command raising the lowest version to a higher one currently stated in the composer.json
  12. core-ci voted on patch set 3 V +1 10/04/25, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85990

  13. Chris Müller voted on patch set 3 CR 0 V 0 10/04/25, 08:39

  14. Stefan Bürk uploaded patch set 4 CR +1 V +1 10/04/25, 08:45

  15. Stefan Bürk commented on patch set 4 CR +1 V +1 10/04/25, 08:48

    Reply

    Done
  16. Chris Müller voted on patch set 4 CR +1 V +1 10/04/25, 08:56

  17. core-ci voted on patch set 4 V -1 10/04/25, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85996

  18. core-ci voted on patch set 4 V +1 10/04/25, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85996

  19. Stefan Bürk voted on patch set 4 CR +2 V +2 10/04/25, 09:36

  20. Stefan Bürk merged patch set 5 10/04/25, 09:36