90890[TASK] Update phpstan to 2.1.30
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Chris Müller +1
-
Verified V +2 Done
- Stefan Bürk +2
- Chris Müller +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1520
-
Garvin Hicking uploaded patch set 1 10/03/25, 18:55
-
core-ci voted on patch set 1 V -1 10/03/25, 19:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85962
-
Garvin Hicking uploaded patch set 2
V -110/04/25, 07:53 -
core-ci voted on patch set 2 V +1 10/04/25, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85983
-
Stefan Bürk voted on patch set 2 CR +1 V +1 10/04/25, 08:24
-
Stefan Bürk commented on patch set 2 CR 0 V 0 10/04/25, 08:26
Update should use ``` composer req --dev phpstan/phpstan:^2.1.30 -W ``` directly. Same for backports. -
Garvin Hicking updated the commit message in patch set 3
V +110/04/25, 08:29 -
Garvin Hicking commented on patch set 3 10/04/25, 08:29
Reply
copy pasta -
Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/04/25, 08:36
-
Chris Müller voted on patch set 3 CR +1 V +1 10/04/25, 08:38
-
Stefan Bürk commented on patch set 3 CR -1 10/04/25, 08:38
Reply
Not only commit message, the changed command needs to be executed. Update in `composer.json` is missing and not reflecting the executed require command raising the lowest version to a higher one currently stated in the composer.json -
core-ci voted on patch set 3 V +1 10/04/25, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85990
-
Chris Müller voted on patch set 3 CR 0 V 0 10/04/25, 08:39
-
Stefan Bürk uploaded patch set 4
CR +1V +110/04/25, 08:45 -
Stefan Bürk commented on patch set 4 CR +1 V +1 10/04/25, 08:48
Reply
Done -
Chris Müller voted on patch set 4 CR +1 V +1 10/04/25, 08:56
-
core-ci voted on patch set 4 V -1 10/04/25, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85996
-
core-ci voted on patch set 4 V +1 10/04/25, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85996
-
Stefan Bürk voted on patch set 4 CR +2 V +2 10/04/25, 09:36
-
Stefan Bürk merged patch set 5 10/04/25, 09:36