90900[TASK] Cleanup TYPO3\CMS\Core\Http\Response
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1116
-
Torben Hansen uploaded patch set 1 10/04/25, 10:35
-
core-ci voted on patch set 1 V -1 10/04/25, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86005
-
Torben Hansen uploaded patch set 2
V -110/04/25, 10:56 -
core-ci voted on patch set 2 V -1 10/04/25, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86006
-
Torben Hansen uploaded patch set 3
V -110/04/25, 11:49 -
core-ci voted on patch set 3 V -1 10/04/25, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86007
-
Torben Hansen uploaded patch set 4
V -110/04/25, 12:21 -
core-ci voted on patch set 4 V +1 10/04/25, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86009
-
Chris Müller commented on patch set 4 10/04/25, 12:37
-
Torben Hansen uploaded patch set 5
V +110/04/25, 17:16 -
Torben Hansen commented on patch set 5 10/04/25, 17:17
Response.php:116ReplyGood catch. I added the `is_string` check which resulted in additional removal of 2 phpstan baseline excludes. -
core-ci voted on patch set 5 V +1 10/04/25, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86016
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 10/04/25, 17:28
-
Garvin Hicking voted on patch set 5 CR +1 V +1 10/04/25, 21:00
-
Benni Mack voted on patch set 5 CR +2 V +2 10/05/25, 11:13
-
Benni Mack merged patch set 6 10/05/25, 11:13
Response.php:116