90904[BUGFIX] Prevent infinite loop in scheduler invalid task deletion
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Lina Wolf +1
- Josua Vogel +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Lina Wolf +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1118
-
Garvin Hicking uploaded patch set 1 10/04/25, 20:22
-
core-ci voted on patch set 1 V -1 10/04/25, 20:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86018
-
core-ci voted on patch set 1 V +1 10/04/25, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86018
-
Garvin Hicking updated the commit message in patch set 2
V +110/04/25, 21:30 -
core-ci voted on patch set 2 V +1 10/04/25, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86021
-
Oli Bartsch uploaded patch set 3
V +110/05/25, 10:10 -
Oli Bartsch updated the commit message in patch set 4 10/05/25, 10:11
-
core-ci voted on patch set 4 V -1 10/05/25, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86034
-
core-ci voted on patch set 3 V -1 10/05/25, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86033
-
core-ci voted on patch set 4 V +1 10/05/25, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86034
-
Garvin Hicking commented on patch set 4 V -1 10/06/25, 06:27
Latest patchset still has the infinite infite recursion recursion. `$row['disabled']` never gets set to `1`. -
Oli Bartsch uploaded patch set 5
V +110/06/25, 08:55 -
core-ci voted on patch set 5 V +1 10/06/25, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86065
-
Garvin Hicking commented on patch set 5 CR +1 V +1 10/06/25, 12:23
Voting on Oli's approach, this works for me (it would not sys_log a change of this due to direct connection pool approach but I suppose that's acceptable) -
Lina Wolf commented on patch set 5 CR +1 V +1 10/09/25, 06:18
This change allows me to successfully remove my faulty task. The code change looks good to me, I find it acceptable if this interaction is not logged. -
Josua Vogel voted on patch set 5 CR +1 10/09/25, 07:02
-
Oli Bartsch voted on patch set 5 CR +2 V +2 10/09/25, 07:09
-
Oli Bartsch merged patch set 6 10/09/25, 07:09